[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.2 v2 5/9] pc-bios/s390-ccw: Do not bail out early if no
From: |
Cornelia Huck |
Subject: |
Re: [PATCH for-5.2 v2 5/9] pc-bios/s390-ccw: Do not bail out early if not finding a SCSI disk |
Date: |
Thu, 6 Aug 2020 13:20:28 +0200 |
On Thu, 6 Aug 2020 12:53:45 +0200
Thomas Huth <thuth@redhat.com> wrote:
> In case the user did not specify a boot device, we want to continue
> looking for other devices if there are no valid SCSI disks on a virtio-
> scsi controller. As a first step, do not panic in this case and let
> the control flow carry the error to the upper functions instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/main.c | 14 ++++++++++----
> pc-bios/s390-ccw/s390-ccw.h | 2 +-
> pc-bios/s390-ccw/virtio-blkdev.c | 7 +++++--
> pc-bios/s390-ccw/virtio-scsi.c | 28 ++++++++++++++++++++--------
> pc-bios/s390-ccw/virtio-scsi.h | 2 +-
> 5 files changed, 37 insertions(+), 16 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
- [PATCH for-5.2 v2 1/9] pc-bios/s390-ccw/Makefile: Compile with -std=gnu99, -fwrapv and -fno-common, (continued)
- [PATCH for-5.2 v2 1/9] pc-bios/s390-ccw/Makefile: Compile with -std=gnu99, -fwrapv and -fno-common, Thomas Huth, 2020/08/06
- [PATCH for-5.2 v2 2/9] pc-bios/s390-ccw: Move ipl-related code from main() into a separate function, Thomas Huth, 2020/08/06
- [PATCH for-5.2 v2 3/9] pc-bios/s390-ccw: Introduce ENODEV define and remove guards of others, Thomas Huth, 2020/08/06
- [PATCH for-5.2 v2 4/9] pc-bios/s390-ccw: Move the inner logic of find_subch() to a separate function, Thomas Huth, 2020/08/06
- [PATCH for-5.2 v2 5/9] pc-bios/s390-ccw: Do not bail out early if not finding a SCSI disk, Thomas Huth, 2020/08/06
- Re: [PATCH for-5.2 v2 5/9] pc-bios/s390-ccw: Do not bail out early if not finding a SCSI disk,
Cornelia Huck <=
- [PATCH for-5.2 v2 6/9] pc-bios/s390-ccw: Scan through all devices if no boot device specified, Thomas Huth, 2020/08/06
- [PATCH for-5.2 v2 7/9] pc-bios/s390-ccw: Allow booting in case the first virtio-blk disk is bad, Thomas Huth, 2020/08/06
- [PATCH for-5.2 v2 8/9] pc-bios/s390-ccw/main: Remove superfluous call to enable_subchannel(), Thomas Huth, 2020/08/06
- [PATCH for-5.2 v2 9/9] tests/qtest/cdrom: Add more s390x-related boot tests, Thomas Huth, 2020/08/06
- Re: [PATCH for-5.2 v2 9/9] tests/qtest/cdrom: Add more s390x-related boot tests, Janosch Frank, 2020/08/06