Re: [PATCH] softmmu: Add missing trace-events file

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> On 8/5/20 3:27 PM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>> 
>>> Commit c7f419f584 moved softmmu-only files out of the root
>>> directory, but forgot to move the trace events, which should
>>> no longer be generated to "trace-root.h". Fix that by adding
>>> softmmu/trace-events.
>> 
>> Dang!  I'd like to have this in 5.1 if at all possible.
>> 
> [...]
>> 
>> scripts/cleanup-trace-events.pl finds these (and corrects them in-place,
>> which is not what we want here).  It finds a few more.  I'll look more
>> closely and report back.
>
> Congratulation, you just found the first job you'll add to our GitLab CI
> =)

cleanup-trace-events.pl is not fit for use in CI; see the list of
funnies in "[PATCH 4/4] trace-events: Fix attribution of trace points to
source".  Perhaps it could be sufficiently improved.