[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] softmmu: Add missing trace-events file
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] softmmu: Add missing trace-events file |
Date: |
Thu, 6 Aug 2020 17:10:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 8/6/20 4:24 PM, Claudio Fontana wrote:
> On 8/6/20 4:21 PM, Paolo Bonzini wrote:
>> On 05/08/20 15:27, Markus Armbruster wrote:
>>>> Commit c7f419f584 moved softmmu-only files out of the root
>>>> directory, but forgot to move the trace events, which should
>>>> no longer be generated to "trace-root.h". Fix that by adding
>>>> softmmu/trace-events.
>>> Dang! I'd like to have this in 5.1 if at all possible.
>>>
>>
>> Does this matter at all for usage of tracepoints?
Markus said on IRC it is a false alarm, can wait 5.2 :)
>>
>> Paolo
>>
>>
>
> Hi Paolo, I tested both with and without the fix,
> the events seem to be generated anyway.
>
> Using simple trace backend, simple smoke test tracing the
> memory_region_ops_read from softmmu/memory.c
>
> Thanks,
>
> Claudio
>