[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 1/9] hw/pci-host: add pci-intack write method
From: |
P J P |
Subject: |
[PATCH v4 1/9] hw/pci-host: add pci-intack write method |
Date: |
Tue, 11 Aug 2020 17:11:25 +0530 |
From: Prasad J Pandit <pjp@fedoraproject.org>
Add pci-intack mmio write method to avoid NULL pointer dereference
issue.
Reported-by: Lei Sun <slei.casper@gmail.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/pci-host/prep.c | 8 ++++++++
1 file changed, 8 insertions(+)
Update v4: add Reviewed-by tag
-> https://lists.nongnu.org/archive/html/qemu-devel/2020-07/msg05325.html
diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c
index 4b93fd2b01..64b33af6c0 100644
--- a/hw/pci-host/prep.c
+++ b/hw/pci-host/prep.c
@@ -26,6 +26,7 @@
#include "qemu/osdep.h"
#include "qemu-common.h"
#include "qemu/units.h"
+#include "qemu/log.h"
#include "qapi/error.h"
#include "hw/pci/pci.h"
#include "hw/pci/pci_bus.h"
@@ -119,8 +120,15 @@ static uint64_t raven_intack_read(void *opaque, hwaddr
addr,
return pic_read_irq(isa_pic);
}
+static void raven_intack_write(void *opaque, hwaddr addr,
+ uint64_t data, unsigned size)
+{
+ qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__);
+}
+
static const MemoryRegionOps raven_intack_ops = {
.read = raven_intack_read,
+ .write = raven_intack_write,
.valid = {
.max_access_size = 1,
},
--
2.26.2
- [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks, P J P, 2020/08/11
- [PATCH v4 1/9] hw/pci-host: add pci-intack write method,
P J P <=
- [PATCH v4 2/9] pci-host: designware: add pcie-msi read method, P J P, 2020/08/11
- [PATCH v4 3/9] vfio: add quirk device write method, P J P, 2020/08/11
- [PATCH v4 4/9] prep: add ppc-parity write method, P J P, 2020/08/11
- [PATCH v4 5/9] nvram: add nrf51_soc flash read method, P J P, 2020/08/11
- [PATCH v4 6/9] spapr_pci: add spapr msi read method, P J P, 2020/08/11
- [PATCH v4 7/9] tz-ppc: add dummy read/write methods, P J P, 2020/08/11