[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 4/9] prep: add ppc-parity write method
|
From: |
P J P |
|
Subject: |
[PATCH v4 4/9] prep: add ppc-parity write method |
|
Date: |
Tue, 11 Aug 2020 17:11:28 +0530 |
From: Prasad J Pandit <pjp@fedoraproject.org>
Add ppc-parity mmio write method to avoid NULL pointer dereference
issue.
Reported-by: Lei Sun <slei.casper@gmail.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/ppc/prep_systemio.c | 8 ++++++++
1 file changed, 8 insertions(+)
Update v4: No change, v3 was acked
-> https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg09965.html
diff --git a/hw/ppc/prep_systemio.c b/hw/ppc/prep_systemio.c
index bbc51b6e9a..e583222a1b 100644
--- a/hw/ppc/prep_systemio.c
+++ b/hw/ppc/prep_systemio.c
@@ -23,6 +23,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/log.h"
#include "hw/irq.h"
#include "hw/isa/isa.h"
#include "hw/qdev-properties.h"
@@ -235,8 +236,15 @@ static uint64_t ppc_parity_error_readl(void *opaque,
hwaddr addr,
return val;
}
+static void ppc_parity_error_writel(void *opaque, hwaddr addr,
+ uint64_t data, unsigned size)
+{
+ qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid access\n", __func__);
+}
+
static const MemoryRegionOps ppc_parity_error_ops = {
.read = ppc_parity_error_readl,
+ .write = ppc_parity_error_writel,
.valid = {
.min_access_size = 4,
.max_access_size = 4,
--
2.26.2
- [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks, P J P, 2020/08/11
- [PATCH v4 1/9] hw/pci-host: add pci-intack write method, P J P, 2020/08/11
- [PATCH v4 2/9] pci-host: designware: add pcie-msi read method, P J P, 2020/08/11
- [PATCH v4 3/9] vfio: add quirk device write method, P J P, 2020/08/11
- [PATCH v4 4/9] prep: add ppc-parity write method,
P J P <=
- [PATCH v4 5/9] nvram: add nrf51_soc flash read method, P J P, 2020/08/11
- [PATCH v4 6/9] spapr_pci: add spapr msi read method, P J P, 2020/08/11
- [PATCH v4 7/9] tz-ppc: add dummy read/write methods, P J P, 2020/08/11
- [PATCH v4 8/9] imx7-ccm: add digprog mmio write method, P J P, 2020/08/11
- [PATCH v4 9/9] memory: assert MemoryRegionOps callbacks are defined, P J P, 2020/08/11