Re: [PATCH 1/1] qga: add command guest-get-disks

[Michael Roth]

Quoting Philippe Mathieu-Daudé (2020-08-06 05:44:44)
> On 8/6/20 11:03 AM, Tomáš Golembiovský wrote:
> > The command guest-get-fsinfo can be used to list information about disks and
> > partitions but it is limited only to mounted disks with filesystem. This new
> > command allows listing information about attached root disks of the VM. 
> > This is
> > usefull for management applications for mapping virtualized devices or
> > pass-through devices to device names in the guest OS.
> > 
> > Output is similar to the list of partitions of guest-get-fsinfo, except that
> > the disks are mapped instead of partitions.
> > 
> > Example output:
> > 
> > {
> >   "return": [
> >     {
> >       "serial": "SAMSUNG_123456789",
> >       "bus-type": "sata",
> >       "bus": 0,
> >       "unit": 0,
> >       "pci-controller": {
> >         "bus": 0,
> >         "slot": 31,
> >         "domain": 0,
> >         "function": 2
> >       },
> >       "dev": "/dev/sda",
> >       "target": 0
> >     },
> >     ...
> >   ]
> > }
> > 
> > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> > ---
> >  qga/commands-posix.c | 91 +++++++++++++++++++++++++++++++++++++++++++-
> >  qga/commands-win32.c | 83 ++++++++++++++++++++++++++++++++++++++++
> >  qga/qapi-schema.json | 13 +++++++
> >  3 files changed, 186 insertions(+), 1 deletion(-)
> 
> Not sure this is better, but splitting this in 3 could help different
> people reviewing (developers not familiar with the Windows API might
> feel not comfortable adding a R-b tag for the POSIX part, and
> reciprocally).
> 
> 1/ qapi + stubs
> 2/ POSIX implementation
> 3/ Win32 implementation
> 

+1