[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] target/ppc: Integrate icount to purr, vtb, and tbu40
From: |
Richard Henderson |
Subject: |
Re: [PATCH v2] target/ppc: Integrate icount to purr, vtb, and tbu40 |
Date: |
Wed, 12 Aug 2020 14:33:33 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/11/20 8:32 AM, Gustavo Romero wrote:
> Currently if option '-icount auto' is passed to the QEMU TCG to enable
> counting instructions the VM crashes with the following error report when
> Linux runs on it:
>
> qemu-system-ppc64: Bad icount read
>
> This happens because read/write access to the SPRs PURR, VTB, and TBU40
> is not integrated to the icount framework.
>
> This commit fixes that issue by making the read/write access of these
> SPRs aware of icount framework, adding the proper gen_io_start() calls
> before calling the helpers to load/store these SPRs in TCG and ensuring
> that the associated TBs end immediately after, accordingly to what's in
> docs/devel/tcg-icount.rst.
>
> Signed-off-by: Gustavo Romero <gromero@linux.ibm.com>
> ---
> target/ppc/translate_init.inc.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~