Re: [PATCH v2] target/ppc: Integrate icount to purr, vtb, and tbu40

[Gustavo Romero]

On 8/12/20 9:03 PM, David Gibson wrote:
> On Wed, Aug 12, 2020 at 02:33:33PM -0700, Richard Henderson wrote:
> > On 8/11/20 8:32 AM, Gustavo Romero wrote:
> > > Currently if option '-icount auto' is passed to the QEMU TCG to enable
> > > counting instructions the VM crashes with the following error report when
> > > Linux runs on it:
> > >
> > > qemu-system-ppc64: Bad icount read
> > >
> > > This happens because read/write access to the SPRs PURR, VTB, and TBU40
> > > is not integrated to the icount framework.
> > >
> > > This commit fixes that issue by making the read/write access of these
> > > SPRs aware of icount framework, adding the proper gen_io_start() calls
> > > before calling the helpers to load/store these SPRs in TCG and ensuring
> > > that the associated TBs end immediately after, accordingly to what's in
> > > docs/devel/tcg-icount.rst.
> > >
> > > Signed-off-by: Gustavo Romero <gromero@linux.ibm.com>
> > > ---
> > >   target/ppc/translate_init.inc.c | 30 ++++++++++++++++++++++++++++++
> > >   1 file changed, 30 insertions(+)
> >
> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> Applied to ppc-for-5.2, thanks.

Thanks Peter, Richard and David.


Best regards,
Gustavo