[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks
|
From: |
David Gibson |
|
Subject: |
Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks |
|
Date: |
Thu, 13 Aug 2020 16:36:44 +1000 |
On Tue, Aug 11, 2020 at 05:11:24PM +0530, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> Hello,
>
> * This series asserts that MemoryRegionOps objects define read/write
> callback methods. Thus avoids potential NULL pointer dereference.
> ex. ->
> https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef34617eb1344f5276292cadd326c21b2
>
> * Also adds various undefined MemoryRegionOps read/write functions
> to avoid potential assert failure.
The overall idea seems fine. Looks like we could avoid a fair bit of
boilerplate - and slightly reduce our binary size - by introducing a
global unimplemented_write() function.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [PATCH v4 4/9] prep: add ppc-parity write method, (continued)
- [PATCH v4 5/9] nvram: add nrf51_soc flash read method, P J P, 2020/08/11
- [PATCH v4 6/9] spapr_pci: add spapr msi read method, P J P, 2020/08/11
- [PATCH v4 7/9] tz-ppc: add dummy read/write methods, P J P, 2020/08/11
- [PATCH v4 8/9] imx7-ccm: add digprog mmio write method, P J P, 2020/08/11
- [PATCH v4 9/9] memory: assert MemoryRegionOps callbacks are defined, P J P, 2020/08/11
- Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks,
David Gibson <=
- Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks, Philippe Mathieu-Daudé, 2020/08/16