[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/9] scripts/tracetool: Use void pointer for vcpu
From: |
Stefan Hajnoczi |
Subject: |
[PULL 2/9] scripts/tracetool: Use void pointer for vcpu |
Date: |
Thu, 13 Aug 2020 06:22:50 +0100 |
From: Roman Bolshakov <r.bolshakov@yadro.com>
dtrace on macOS complains that CPUState * is used for a few probes:
dtrace: failed to compile script trace-dtrace-root.dtrace: line 130: syntax
error near "CPUState"
A comment in scripts/tracetool/__init__.py mentions that:
We only want to allow standard C types or fixed sized
integer types. We don't want QEMU specific types
as we can't assume trace backends can resolve all the
typedefs
Fixes: 3d211d9f4dbee ("trace: Add 'vcpu' event property to trace guest vCPU")
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Message-id: 20200717093517.73397-3-r.bolshakov@yadro.com
Cc: Cameron Esfahani <dirty@apple.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
scripts/tracetool/vcpu.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/tracetool/vcpu.py b/scripts/tracetool/vcpu.py
index b54e4f4e7a..868b4cb04c 100644
--- a/scripts/tracetool/vcpu.py
+++ b/scripts/tracetool/vcpu.py
@@ -24,7 +24,7 @@ def transform_event(event):
assert "tcg-trans" not in event.properties
assert "tcg-exec" not in event.properties
- event.args = Arguments([("CPUState *", "__cpu"), event.args])
+ event.args = Arguments([("void *", "__cpu"), event.args])
if "tcg" in event.properties:
fmt = "\"cpu=%p \""
event.fmt = [fmt + event.fmt[0],
--
2.26.2
- [PULL 0/9] Tracing patches, Stefan Hajnoczi, 2020/08/13
- [PULL 1/9] scripts/tracetool: Fix dtrace generation for macOS, Stefan Hajnoczi, 2020/08/13
- [PULL 2/9] scripts/tracetool: Use void pointer for vcpu,
Stefan Hajnoczi <=
- [PULL 4/9] net/colo: Match is-enabled probe to tracepoint, Stefan Hajnoczi, 2020/08/13
- [PULL 3/9] build: Don't make object files for dtrace on macOS, Stefan Hajnoczi, 2020/08/13
- [PULL 5/9] softmmu: Add missing trace-events file, Stefan Hajnoczi, 2020/08/13
- [PULL 6/9] scripts/cleanup-trace-events: Fix for vcpu property, Stefan Hajnoczi, 2020/08/13
- [PULL 7/9] scripts/cleanup-trace-events: Emit files in alphabetical order, Stefan Hajnoczi, 2020/08/13
- [PULL 8/9] trace-events: Delete unused trace points, Stefan Hajnoczi, 2020/08/13
- [PULL 9/9] trace-events: Fix attribution of trace points to source, Stefan Hajnoczi, 2020/08/13
- Re: [PULL 0/9] Tracing patches, no-reply, 2020/08/13
- Re: [PULL 0/9] Tracing patches, no-reply, 2020/08/13