[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/9] build: Don't make object files for dtrace on macOS
From: |
Stefan Hajnoczi |
Subject: |
[PULL 3/9] build: Don't make object files for dtrace on macOS |
Date: |
Thu, 13 Aug 2020 06:22:51 +0100 |
From: Roman Bolshakov <r.bolshakov@yadro.com>
dtrace on macOS uses unresolved symbols with a special prefix to define
probes [1], only headers should be generated for USDT (dtrace(1)). But
it doesn't support backwards compatible no-op -G flag [2] and implicit
build rules fail.
1. https://markmail.org/message/6grq2ygr5nwdwsnb
2. https://markmail.org/message/5xrxt2w5m42nojkz
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Message-id: 20200717093517.73397-4-r.bolshakov@yadro.com
Cc: Cameron Esfahani <dirty@apple.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
Makefile.objs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile.objs b/Makefile.objs
index d22b3b45d7..982f15ba30 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -211,5 +211,7 @@ trace-events-files = $(SRC_PATH)/trace-events
$(trace-events-subdirs:%=$(SRC_PAT
trace-obj-y = trace-root.o
trace-obj-y += $(trace-events-subdirs:%=%/trace.o)
trace-obj-$(CONFIG_TRACE_UST) += trace-ust-all.o
+ifneq ($(CONFIG_DARWIN),y)
trace-obj-$(CONFIG_TRACE_DTRACE) += trace-dtrace-root.o
trace-obj-$(CONFIG_TRACE_DTRACE) += $(trace-events-subdirs:%=%/trace-dtrace.o)
+endif
--
2.26.2
- [PULL 0/9] Tracing patches, Stefan Hajnoczi, 2020/08/13
- [PULL 1/9] scripts/tracetool: Fix dtrace generation for macOS, Stefan Hajnoczi, 2020/08/13
- [PULL 2/9] scripts/tracetool: Use void pointer for vcpu, Stefan Hajnoczi, 2020/08/13
- [PULL 4/9] net/colo: Match is-enabled probe to tracepoint, Stefan Hajnoczi, 2020/08/13
- [PULL 3/9] build: Don't make object files for dtrace on macOS,
Stefan Hajnoczi <=
- [PULL 5/9] softmmu: Add missing trace-events file, Stefan Hajnoczi, 2020/08/13
- [PULL 6/9] scripts/cleanup-trace-events: Fix for vcpu property, Stefan Hajnoczi, 2020/08/13
- [PULL 7/9] scripts/cleanup-trace-events: Emit files in alphabetical order, Stefan Hajnoczi, 2020/08/13
- [PULL 8/9] trace-events: Delete unused trace points, Stefan Hajnoczi, 2020/08/13
- [PULL 9/9] trace-events: Fix attribution of trace points to source, Stefan Hajnoczi, 2020/08/13
- Re: [PULL 0/9] Tracing patches, no-reply, 2020/08/13
- Re: [PULL 0/9] Tracing patches, no-reply, 2020/08/13
- Re: [PULL 0/9] Tracing patches, Peter Maydell, 2020/08/21