[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 07/10] migration/dirtyrate: skip sampling ramblock with size b
From: |
Chuan Zheng |
Subject: |
[PATCH v2 07/10] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE |
Date: |
Sat, 15 Aug 2020 10:22:57 +0800 |
From: Zheng Chuan <zhengchuan@huawei.com>
In order to sample real RAM, skip ramblock with size below
MIN_RAMBLOCK_SIZE which is 128M as default.
Signed-off-by: Zheng Chuan <zhengchuan@huawei.com>
---
migration/dirtyrate.c | 24 ++++++++++++++++++++++++
migration/dirtyrate.h | 5 +++++
2 files changed, 29 insertions(+)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index f136067..3dc9feb 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -179,6 +179,24 @@ alloc_ramblock_dirty_info(int *block_index,
return block_dinfo;
}
+static int skip_sample_ramblock(RAMBlock *block)
+{
+ int64_t ramblock_size;
+
+ /* ramblock size in MB */
+ ramblock_size = qemu_ram_get_used_length(block) >> 20;
+
+ /*
+ * Consider ramblock with size larger than 128M is what we
+ * want to sample.
+ */
+ if (ramblock_size < MIN_RAMBLOCK_SIZE) {
+ return -1;
+ }
+
+ return 0;
+}
+
static int record_ramblock_hash_info(struct DirtyRateConfig config,
struct RamblockDirtyInfo **block_dinfo,
int *block_index)
{
@@ -188,6 +206,9 @@ static int record_ramblock_hash_info(struct DirtyRateConfig
config,
int index = 0;
RAMBLOCK_FOREACH_MIGRATABLE(block) {
+ if (skip_sample_ramblock(block) < 0) {
+ continue;
+ }
dinfo = alloc_ramblock_dirty_info(&index, dinfo);
if (dinfo == NULL)
return -1;
@@ -263,6 +284,9 @@ static int compare_page_hash_info(struct RamblockDirtyInfo
*info, int block_inde
RAMBlock *block = NULL;
RAMBLOCK_FOREACH_MIGRATABLE(block) {
+ if (skip_sample_ramblock(block) < 0) {
+ continue;
+ }
block_dinfo = NULL;
if (!find_page_matched(block, info, block_index + 1, &block_dinfo)) {
continue;
diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h
index 0812b16..fce2e3b 100644
--- a/migration/dirtyrate.h
+++ b/migration/dirtyrate.h
@@ -31,6 +31,11 @@
#define QCRYPTO_HASH_LEN 16
+/*
+ * minimum ramblock size to sampled
+ */
+#define MIN_RAMBLOCK_SIZE 128
+
/* Take 1s as default for calculation duration */
#define DEFAULT_FETCH_DIRTYRATE_TIME_SEC 1
--
1.8.3.1
- [PATCH v2 04/10] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h, (continued)
- [PATCH v2 04/10] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h, Chuan Zheng, 2020/08/14
- [PATCH v2 00/10] *** A Method for evaluating dirty page rate ***, Chuan Zheng, 2020/08/15
- [PATCH v2 02/10] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info, Chuan Zheng, 2020/08/15
- [PATCH v2 10/10] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function, Chuan Zheng, 2020/08/15
- [PATCH v2 09/10] migration/dirtyrate: Implement calculate_dirtyrate() function, Chuan Zheng, 2020/08/15
- [PATCH v2 08/10] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period(), Chuan Zheng, 2020/08/15
- [PATCH v2 05/10] migration/dirtyrate: Record hash results for each sampled page, Chuan Zheng, 2020/08/15
- [PATCH v2 03/10] migration/dirtyrate: Add dirtyrate statistics series functions, Chuan Zheng, 2020/08/15
- [PATCH v2 04/10] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h, Chuan Zheng, 2020/08/15
- [PATCH v2 06/10] migration/dirtyrate: Compare page hash results for recorded sampled page, Chuan Zheng, 2020/08/15
- [PATCH v2 07/10] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE,
Chuan Zheng <=
- [PATCH v2 01/10] migration/dirtyrate: Add get_dirtyrate_thread() function, Chuan Zheng, 2020/08/15
- Re: [PATCH v2 00/10] *** A Method for evaluating dirty page rate ***, no-reply, 2020/08/15
- Re: [PATCH v2 00/10] *** A Method for evaluating dirty page rate ***, no-reply, 2020/08/15
- Re: [PATCH v2 00/10] *** A Method for evaluating dirty page rate ***, no-reply, 2020/08/15