Re: [PATCH v2 00/10] *** A Method for evaluating dirty page rate ***

[no-reply]

Patchew URL: 
1597458180-16945-1-git-send-email-zhengchuan@huawei.com/">https://patchew.org/QEMU/1597458180-16945-1-git-send-email-zhengchuan@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1597458180-16945-1-git-send-email-zhengchuan@huawei.com
Subject: [PATCH v2 00/10] *** A Method for evaluating dirty page rate ***

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9895a95 migration/dirtyrate: Implement 
qmp_cal_dirty_rate()/qmp_get_dirty_rate() function
b1e62b0 migration/dirtyrate: Implement calculate_dirtyrate() function
422368f migration/dirtyrate: Implement get_sample_page_period() and 
block_sample_page_period()
b83696a migration/dirtyrate: skip sampling ramblock with size below 
MIN_RAMBLOCK_SIZE
1e807c0 migration/dirtyrate: Compare page hash results for recorded sampled page
383d30a migration/dirtyrate: Record hash results for each sampled page
95a361f migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h
07d224f migration/dirtyrate: Add dirtyrate statistics series functions
dfd9476 migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info
1b3ba07 migration/dirtyrate: Add get_dirtyrate_thread() function

=== OUTPUT BEGIN ===
1/10 Checking commit 1b3ba075587a (migration/dirtyrate: Add 
get_dirtyrate_thread() function)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 115 lines checked

Patch 1/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit dfd947626dc5 (migration/dirtyrate: Add RamlockDirtyInfo to 
store sampled page info)
3/10 Checking commit 07d224f2772b (migration/dirtyrate: Add dirtyrate 
statistics series functions)
4/10 Checking commit 95a361f00817 (migration/dirtyrate: move 
RAMBLOCK_FOREACH_MIGRATABLE into ram.h)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#62: FILE: migration/ram.h:42:
+#define RAMBLOCK_FOREACH_NOT_IGNORED(block)            \
+    INTERNAL_RAMBLOCK_FOREACH(block)                   \
+        if (ramblock_is_ignored(block)) {} else

ERROR: trailing statements should be on next line
#64: FILE: migration/ram.h:44:
+        if (ramblock_is_ignored(block)) {} else

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#66: FILE: migration/ram.h:46:
+#define RAMBLOCK_FOREACH_MIGRATABLE(block)             \
+    INTERNAL_RAMBLOCK_FOREACH(block)                   \
+        if (!qemu_ram_is_migratable(block)) {} else

ERROR: trailing statements should be on next line
#68: FILE: migration/ram.h:48:
+        if (!qemu_ram_is_migratable(block)) {} else

ERROR: braces {} are necessary for all arms of this statement
#68: FILE: migration/ram.h:48:
+        if (!qemu_ram_is_migratable(block)) {} else
[...]
+        if (!qemu_ram_is_migratable(block)) {} else
[...]

total: 5 errors, 0 warnings, 45 lines checked

Patch 4/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/10 Checking commit 383d30ad41de (migration/dirtyrate: Record hash results for 
each sampled page)
WARNING: line over 80 characters
#33: FILE: migration/dirtyrate.c:79:
+static int get_ramblock_vfn_hash(struct RamblockDirtyInfo *info, unsigned long 
vfn,

ERROR: "foo* bar" should be "foo *bar"
#59: FILE: migration/dirtyrate.c:105:
+    GRand* rand = g_rand_new();

ERROR: line over 90 characters
#69: FILE: migration/dirtyrate.c:115:
+    info->hash_result = g_try_malloc0_n(sample_pages_count, sizeof(uint8_t) * 
qcrypto_hash_len);

WARNING: line over 80 characters
#75: FILE: migration/dirtyrate.c:121:
+    info->sample_page_vfn = g_try_malloc0_n(sample_pages_count, 
sizeof(unsigned long));

WARNING: line over 80 characters
#84: FILE: migration/dirtyrate.c:130:
+        info->sample_page_vfn[i] = g_rand_int_range(rand, 0, 
info->ramblock_pages - 1);

WARNING: line over 80 characters
#97: FILE: migration/dirtyrate.c:143:
+static void get_ramblock_dirty_info(RAMBlock *block, struct RamblockDirtyInfo 
*info,

ERROR: line over 90 characters
#103: FILE: migration/dirtyrate.c:149:
+    info->sample_pages_count = (qemu_ram_get_used_length(block) * 
sample_pages_per_gigabytes) >> 30;

ERROR: braces {} are necessary for all arms of this statement
#126: FILE: migration/dirtyrate.c:172:
+    if (!block_dinfo)
[...]

ERROR: line over 90 characters
#137: FILE: migration/dirtyrate.c:183:
+                                     struct RamblockDirtyInfo **block_dinfo, 
int *block_index)

ERROR: braces {} are necessary for all arms of this statement
#146: FILE: migration/dirtyrate.c:192:
+        if (dinfo == NULL)
[...]

total: 6 errors, 4 warnings, 164 lines checked

Patch 5/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/10 Checking commit 1e807c015c51 (migration/dirtyrate: Compare page hash 
results for recorded sampled page)
ERROR: braces {} are necessary for all arms of this statement
#28: FILE: migration/dirtyrate.c:216:
+    if (!md)
[...]

WARNING: line over 80 characters
#37: FILE: migration/dirtyrate.c:225:
+        if (memcmp(md, info->hash_result + i * qcrypto_hash_len, 
qcrypto_hash_len) != 0) {

WARNING: line over 80 characters
#72: FILE: migration/dirtyrate.c:260:
+static int compare_page_hash_info(struct RamblockDirtyInfo *info, int 
block_index)

total: 1 errors, 2 warnings, 79 lines checked

Patch 6/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/10 Checking commit b83696ab4e41 (migration/dirtyrate: skip sampling ramblock 
with size below MIN_RAMBLOCK_SIZE)
8/10 Checking commit 422368fb328b (migration/dirtyrate: Implement 
get_sample_page_period() and block_sample_page_period())
WARNING: line over 80 characters
#38: FILE: migration/dirtyrate.c:47:
+    if (sec <= MIN_FETCH_DIRTYRATE_TIME_SEC || sec > 
MAX_FETCH_DIRTYRATE_TIME_SEC) {

total: 0 errors, 1 warnings, 37 lines checked

Patch 8/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/10 Checking commit b1e62b03b437 (migration/dirtyrate: Implement 
calculate_dirtyrate() function)
10/10 Checking commit 9895a955bb69 (migration/dirtyrate: Implement 
qmp_cal_dirty_rate()/qmp_get_dirty_rate() function)
ERROR: space required before the open parenthesis '('
#25: FILE: migration/dirtyrate.c:74:
+    switch(CalculatingState) {

total: 1 errors, 0 warnings, 110 lines checked

Patch 10/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
1597458180-16945-1-git-send-email-zhengchuan@huawei.com/testing.checkpatch/?type=message">http://patchew.org/logs/1597458180-16945-1-git-send-email-zhengchuan@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com