Re: [PATCH] audio/jack: fix use after free segfault

[no-reply]

Patchew URL: 
20200818131206.BB75F3A0B9F@moya.office.hostfission.com/">https://patchew.org/QEMU/20200818131206.BB75F3A0B9F@moya.office.hostfission.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200818131206.BB75F3A0B9F@moya.office.hostfission.com
Subject: [PATCH] audio/jack: fix use after free segfault

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
8ec400e audio/jack: fix use after free segfault

=== OUTPUT BEGIN ===
WARNING: line over 80 characters
#40: FILE: audio/jackaudio.c:573:
+         * This will not cause a memory leak as the recovery routine will 
trigger

ERROR: do not use C99 // comments
#46: FILE: audio/jackaudio.c:579:
+        //jack_client_close(c->client);

total: 1 errors, 1 warnings, 23 lines checked

Commit 8ec400ec086a (audio/jack: fix use after free segfault) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200818131206.BB75F3A0B9F@moya.office.hostfission.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200818131206.BB75F3A0B9F@moya.office.hostfission.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com