[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/12] block: simplify comment to BDRV_REQ_SERIALISING
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH v3 01/12] block: simplify comment to BDRV_REQ_SERIALISING |
|
Date: |
Wed, 19 Aug 2020 15:59:18 +0100 |
On Mon, Aug 17, 2020 at 12:15:42PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 1. BDRV_REQ_NO_SERIALISING doesn't exist already, don't mention it.
>
> 2. We are going to add one more user of BDRV_REQ_SERIALISING, so
> comment about backup becomes a bit confusing here. The use case in
> backup is documented in block/backup.c, so let's just drop
> duplication here.
>
> 3. The fact that BDRV_REQ_SERIALISING is only for write requests is
> omitted. Add a note.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> include/block/block.h | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- [PATCH v3 00/12] preallocate filter, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 01/12] block: simplify comment to BDRV_REQ_SERIALISING, Vladimir Sementsov-Ogievskiy, 2020/08/17
- Re: [PATCH v3 01/12] block: simplify comment to BDRV_REQ_SERIALISING,
Stefan Hajnoczi <=
- [PATCH v3 02/12] block/io.c: drop assertion on double waiting for request serialisation, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 03/12] block/io: split out bdrv_find_conflicting_request, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 04/12] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 06/12] block: introduce BDRV_REQ_NO_WAIT flag, Vladimir Sementsov-Ogievskiy, 2020/08/17
- [PATCH v3 05/12] block: bdrv_mark_request_serialising: split non-waiting function, Vladimir Sementsov-Ogievskiy, 2020/08/17