[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Suspicious QOM types without instance/class size
From: |
Alistair Francis |
Subject: |
Re: Suspicious QOM types without instance/class size |
Date: |
Fri, 21 Aug 2020 09:06:51 -0700 |
On Thu, Aug 20, 2020 at 2:56 PM Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> While trying to convert TypeInfo declarations to the new
> OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases
> where instance_size or class_size is not set, despite having type
> checker macros that use a specific type.
>
> The ones with "WARNING" are abstract types (maybe not serious if
> subclasses set the appropriate sizes). The ones with "ERROR"
> don't seem to be abstract types.
>
> ERROR: hw/core/register.c:328:1: instance_size should be set to
> sizeof(RegisterInfo)?
I'll send a patch out for this one today.
If you are fixing all of these as part of a series I'm also happy to
just let you do that.
Alistair
>
> --
> Eduardo
>
>
- Re: Suspicious QOM types without instance/class size, (continued)
- Re: Suspicious QOM types without instance/class size, Cornelia Huck, 2020/08/21
- Re: Suspicious QOM types without instance/class size, Roman Bolshakov, 2020/08/21
- Re: Suspicious QOM types without instance/class size, Eduardo Habkost, 2020/08/21
- Re: Suspicious QOM types without instance/class size, Eduardo Habkost, 2020/08/21
- Re: Suspicious QOM types without instance/class size, Roman Bolshakov, 2020/08/24
- Re: Suspicious QOM types without instance/class size, Eduardo Habkost, 2020/08/24
- Re: Suspicious QOM types without instance/class size, Roman Bolshakov, 2020/08/24
- Re: Suspicious QOM types without instance/class size, Eduardo Habkost, 2020/08/24
Re: Suspicious QOM types without instance/class size,
Alistair Francis <=