[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 02/12] ui/console: fix texture leak when calling surface_gl_cr
From: |
marcandre . lureau |
Subject: |
[PATCH v2 02/12] ui/console: fix texture leak when calling surface_gl_create_texture() |
Date: |
Thu, 17 Feb 2022 15:58:19 +0400 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Make surface_gl_create_texture() idempotent: if the surface is already
bound to a texture, do not create a new one.
This fixes texture leaks when there are multiple DBus listeners, for
example.
Reported-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
ui/console-gl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/ui/console-gl.c b/ui/console-gl.c
index 7c9894a51d99..8e3c9a3c8c01 100644
--- a/ui/console-gl.c
+++ b/ui/console-gl.c
@@ -49,6 +49,10 @@ void surface_gl_create_texture(QemuGLShader *gls,
assert(gls);
assert(QEMU_IS_ALIGNED(surface_stride(surface),
surface_bytes_per_pixel(surface)));
+ if (surface->texture) {
+ return;
+ }
+
switch (surface->format) {
case PIXMAN_BE_b8g8r8x8:
case PIXMAN_BE_b8g8r8a8:
--
2.34.1.428.gdcc0cd074f0c
- [PATCH v2 00/12] GL & D-Bus display related fixes, marcandre . lureau, 2022/02/17
- [PATCH v2 01/12] ui/console: fix crash when using gl context with non-gl listeners, marcandre . lureau, 2022/02/17
- [PATCH v2 02/12] ui/console: fix texture leak when calling surface_gl_create_texture(),
marcandre . lureau <=
- [PATCH v2 03/12] ui: do not create a surface when resizing a GL scanout, marcandre . lureau, 2022/02/17
- [PATCH v2 04/12] ui/console: move check for compatible GL context, marcandre . lureau, 2022/02/17
- [PATCH v2 05/12] ui/console: move dcl compatiblity check to a callback, marcandre . lureau, 2022/02/17
- [PATCH v2 06/12] ui/console: egl-headless is compatible with non-gl listeners, marcandre . lureau, 2022/02/17
- [PATCH v2 07/12] ui/dbus: associate the DBusDisplayConsole listener with the given console, marcandre . lureau, 2022/02/17
- [PATCH v2 08/12] ui/console: move console compatibility check to dcl_display_console(), marcandre . lureau, 2022/02/17
- [PATCH v2 09/12] ui/shader: fix potential leak of shader on error, marcandre . lureau, 2022/02/17
- [PATCH v2 10/12] ui/shader: free associated programs, marcandre . lureau, 2022/02/17
- [PATCH v2 11/12] ui/console: add a dpy_gfx_switch callback helper, marcandre . lureau, 2022/02/17
- [PATCH v2 12/12] ui/dbus: fix texture sharing, marcandre . lureau, 2022/02/17