[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 12/53] semihosting: Clean up common_semi_open_cb
From: |
Richard Henderson |
Subject: |
[PATCH v4 12/53] semihosting: Clean up common_semi_open_cb |
Date: |
Tue, 7 Jun 2022 13:45:16 -0700 |
Use common_semi_cb to return results instead of calling
set_swi_errno and common_semi_set_ret directly.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
semihosting/arm-compat-semi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c
index cc13fcb0ef..6414caa749 100644
--- a/semihosting/arm-compat-semi.c
+++ b/semihosting/arm-compat-semi.c
@@ -364,15 +364,13 @@ static int common_semi_open_guestfd;
static void
common_semi_open_cb(CPUState *cs, target_ulong ret, target_ulong err)
{
- if (ret == (target_ulong)-1) {
- errno = err;
- set_swi_errno(cs, -1);
+ if (err) {
dealloc_guestfd(common_semi_open_guestfd);
} else {
associate_guestfd(common_semi_open_guestfd, ret);
ret = common_semi_open_guestfd;
}
- common_semi_set_ret(cs, ret);
+ common_semi_cb(cs, ret, err);
}
static target_ulong
--
2.34.1
- [PATCH v4 00/53] semihosting cleanup, Richard Henderson, 2022/06/07
- [PATCH v4 01/53] semihosting: Move exec/softmmu-semi.h to semihosting/softmmu-uaccess.h, Richard Henderson, 2022/06/07
- [PATCH v4 06/53] semihosting: Add target_strlen for softmmu-uaccess.h, Richard Henderson, 2022/06/07
- [PATCH v4 09/53] semihosting: Inline set_swi_errno into common_semi_cb, Richard Henderson, 2022/06/07
- [PATCH v4 12/53] semihosting: Clean up common_semi_open_cb,
Richard Henderson <=
- [PATCH v4 04/53] semihosting: Move softmmu-uaccess.h functions out of line, Richard Henderson, 2022/06/07
- [PATCH v4 13/53] semihosting: Return void from do_common_semihosting, Richard Henderson, 2022/06/07
- [PATCH v4 18/53] include/exec: Define errno values in gdbstub.h, Richard Henderson, 2022/06/07
- [PATCH v4 17/53] include/exec: Move gdb_stat and gdb_timeval to gdbstub.h, Richard Henderson, 2022/06/07
- [PATCH v4 03/53] semihosting: Improve condition for config.c and console.c, Richard Henderson, 2022/06/07
- [PATCH v4 07/53] semihosting: Simplify softmmu_lock_user_string, Richard Henderson, 2022/06/07
- [PATCH v4 05/53] accel/stubs: Add tcg stub for probe_access_flags, Richard Henderson, 2022/06/07