qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 13/53] semihosting: Return void from do_common_semihosting


From: Alex Bennée
Subject: Re: [PATCH v4 13/53] semihosting: Return void from do_common_semihosting
Date: Thu, 09 Jun 2022 16:42:17 +0100
User-agent: mu4e 1.7.26; emacs 28.1.50

Richard Henderson <richard.henderson@linaro.org> writes:

> Perform the cleanup in the FIXME comment in common_semi_gdb_syscall.
> Do not modify guest registers until the syscall is complete,
> which in the gdbstub case is asynchronous.
>
> In the synchronous non-gdbstub case, use common_semi_set_ret
> to set the result.  Merge set_swi_errno into common_semi_cb.
> Rely on the latter for combined return value / errno setting.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]