[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 37/51] target/arm: Reset streaming sve state on exception
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 37/51] target/arm: Reset streaming sve state on exception boundaries |
Date: |
Fri, 24 Jun 2022 14:02:41 +0100 |
On Mon, 20 Jun 2022 at 19:14, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> We can handle both exception entry and exception return by
> hooking into aarch64_sve_change_el.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/helper.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 26f4a4bc26..9c5b1a10eb 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -11754,6 +11754,19 @@ void aarch64_sve_change_el(CPUARMState *env, int
> old_el,
> return;
> }
>
> + old_a64 = old_el ? arm_el_is_aa64(env, old_el) : el0_a64;
> + new_a64 = new_el ? arm_el_is_aa64(env, new_el) : el0_a64;
> +
> + /*
> + * Both AArch64.TakeException and AArch64.ExceptionReturn
> + * invoke ResetSVEState when taking an exception from, or
> + * returning to, AArch32 state when PSTATE.SM is enabled.
> + */
> + if (old_a64 != new_a64 && FIELD_EX64(env->svcr, SVCR, SM)) {
> + arm_reset_sve_state(env);
> + return;
> + }
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v3 32/51] target/arm: Implement FMOPA, FMOPS (widening), (continued)
- [PATCH v3 32/51] target/arm: Implement FMOPA, FMOPS (widening), Richard Henderson, 2022/06/20
- [PATCH v3 34/51] target/arm: Implement PSEL, Richard Henderson, 2022/06/20
- [PATCH v3 35/51] target/arm: Implement REVD, Richard Henderson, 2022/06/20
- [PATCH v3 38/51] target/arm: Enable SME for -cpu max, Richard Henderson, 2022/06/20
- [PATCH v3 30/51] target/arm: Implement FMOPA, FMOPS (non-widening), Richard Henderson, 2022/06/20
- [PATCH v3 37/51] target/arm: Reset streaming sve state on exception boundaries, Richard Henderson, 2022/06/20
- Re: [PATCH v3 37/51] target/arm: Reset streaming sve state on exception boundaries,
Peter Maydell <=
- [PATCH v3 33/51] target/arm: Implement SME integer outer product, Richard Henderson, 2022/06/20
- [PATCH v3 44/51] linux-user/aarch64: Verify extra record lock succeeded, Richard Henderson, 2022/06/20
- [PATCH v3 41/51] linux-user/aarch64: Add SM bit to SVE signal context, Richard Henderson, 2022/06/20
- [PATCH v3 43/51] linux-user/aarch64: Do not allow duplicate or short sve records, Richard Henderson, 2022/06/20
- [PATCH v3 47/51] linux-user: Rename sve prctls, Richard Henderson, 2022/06/20
- [PATCH v3 40/51] linux-user/aarch64: Reset PSTATE.SM on syscalls, Richard Henderson, 2022/06/20
- [PATCH v3 45/51] linux-user/aarch64: Move sve record checks into restore, Richard Henderson, 2022/06/20
- [PATCH v3 42/51] linux-user/aarch64: Tidy target_restore_sigframe error return, Richard Henderson, 2022/06/20
- [PATCH v3 50/51] target/arm: Enable SME for user-only, Richard Henderson, 2022/06/20