Re: [PATCH 18/22] tcg/sparc64: Remove USE_REG_TB

[Richard Henderson]

On 12/6/22 01:44, Philippe Mathieu-Daudé wrote:
> On 6/12/22 05:17, Richard Henderson wrote:
> > This is always true for sparc64, so this is dead since 3a5f6805c7ca.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   tcg/sparc64/tcg-target.c.inc | 57 ++++++++++++++----------------------
> >   1 file changed, 22 insertions(+), 35 deletions(-)
>
> > @@ -1897,7 +1884,7 @@ void tb_target_set_jmp_target(const TranslationBlock *tb, 
> > int n,
> >       tcg_debug_assert(tb_disp == (int32_t)tb_disp);
> >       tcg_debug_assert(br_disp == (int32_t)br_disp);
> > -    if (!USE_REG_TB) {
> > +    if (0) {
> >           qatomic_set((uint32_t *)jmp_rw,
> >               deposit32(CALL, 0, 30, br_disp >> 2));
> >           flush_idcache_range(jmp_rx, jmp_rw, 4);
>
> Why remove in the next patch and not here?

Heh.  I did that so I could move this code in the next patch.
I meant to go back and edit this patch to delete, after I'd done that.


r~

> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>