qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-8.0] hw/rtc/mc146818rtc: Make this rtc device target inde


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH for-8.0] hw/rtc/mc146818rtc: Make this rtc device target independent
Date: Tue, 6 Dec 2022 21:17:30 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1

On 6/12/22 21:06, Thomas Huth wrote:
The only code that is really, really target dependent is the apic-related
code in rtc_policy_slew_deliver_irq(). By moving this code into the hw/i386/
folder (renamed to rtc_apic_policy_slew_deliver_irq()) and passing this
function as parameter to mc146818_rtc_init(), we can make the RTC completely
target-independent.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  include/hw/rtc/mc146818rtc.h |  7 +++++--
  hw/alpha/dp264.c             |  2 +-
  hw/hppa/machine.c            |  2 +-
  hw/i386/microvm.c            |  3 ++-
  hw/i386/pc.c                 | 10 +++++++++-
  hw/mips/jazz.c               |  2 +-
  hw/ppc/pnv.c                 |  2 +-
  hw/rtc/mc146818rtc.c         | 34 +++++++++++-----------------------
  hw/rtc/meson.build           |  3 +--
  9 files changed, 32 insertions(+), 33 deletions(-)

Cool!

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]