Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

[Richard Henderson]

On 12/7/22 10:08, Eric Auger wrote:
> On 12/7/22 16:55, Stefan Hajnoczi wrote:
> > > I am using this configure cmd line:
> > >
> > > ./configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib/qemu
> > > --target-list=x86_64-softmmu --docdir=/usr/share/doc/qemu --enable-kvm
> > > --extra-cflags=-O --enable-trace-backends=log --python=/usr/bin/python3
> > > --extra-cflags=-Wall --extra-cflags=-Wundef
> > > --extra-cflags=-Wwrite-strings --extra-cflags=-Wmissing-prototypes
> > > --extra-cflags=-fno-strict-aliasing --extra-cflags=-fno-common
> > > --extra-cflags=-Werror=type-limits
> > > > If you added it manually then let's fix this in 8.0 since it's not
> > > > tested/supported and very few people will see this issue.
> > Did you create the ./configure command-line manually? Do you think
> > other people will hit this?
> no I did not. I just tried to install a fresh qemu repo and just ran the
> above configure command.

Stefan's question is where did you get this configure command?

If it came from an rpm script or suchlike, we might take more notice than if this is just 
you adding --extra-cflags for your own testing.


> I am actually surprised nobody hit that already.

Adding -Wall is not standard, nor all the other -W that you are adding.  I think you 
should not be surprised that you run into problems.

While you can make a case for auditing the code base and adding these to the default set 
of warning flags, that's a job for the next development cycle.


r~