|
| From: | Stefan Weil |
| Subject: | Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized |
| Date: | Wed, 7 Dec 2022 20:11:26 +0100 |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 |
Am 07.12.22 um 19:22 schrieb Eric Auger:
On 12/7/22 17:55, Philippe Mathieu-Daudé wrote:On 7/12/22 15:33, Eric Auger wrote:On 12/7/22 15:09, Stefan Hajnoczi wrote:On Wed, 7 Dec 2022 at 08:31, Eric Auger <eric.auger@redhat.com> wrote:On 12/7/22 14:24, Eric Auger wrote:Initialize r0-3 to avoid compilation errors when -Werror=maybe-uninitialized is used ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: ../target/i386/ops_sse.h:2495:13: error: ‘r3’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 2495 | d->Q(3) = r3; | ~~~~~~~~^~~~ ../target/i386/ops_sse.h:2494:13: error: ‘r2’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 2494 | d->Q(2) = r2; | ~~~~~~~~^~~~ ../target/i386/ops_sse.h:2493:13: error: ‘r1’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 2493 | d->Q(1) = r1; | ~~~~~~~~^~~~ ../target/i386/ops_sse.h:2492:13: error: ‘r0’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 2492 | d->Q(0) = r0; | ~~~~~~~~^~~~ Signed-off-by: Eric Auger <eric.auger@redhat.com> Fixes: 790684776861 ("target/i386: reimplement 0x0f 0x3a, add AVX") --- Am I the only one getting this? Or anything wrong in my setup.
Hi Eric,no, you are not the only one. I regularly build with higher warning levels, for example with -Weverything on macOS, and get a much longer list which includes the mentioned warnings (see below).
The warnings for ops_sse.h are false positives, so I think no fix is needed for 7.2. The compiler is not clever enough to see that the switch statements handle all possible cases. It should be sufficient to replace `case 3` by `default` to help the compiler and fix the warning. Your fix might produce new compiler warnings because setting the variables to 0 has no effect.
Cheers Stefan../block/mirror.c:1024:13: warning: variable 'iostatus' may be uninitialized when used here [-Wconditional-uninitialized] ../block/mirror.c:1498:20: warning: variable 'bounce_buf' may be uninitialized when used here [-Wconditional-uninitialized] ../block/nbd.c:1208:24: warning: variable 'request_ret' may be uninitialized when used here [-Wconditional-uninitialized] ../block/nbd.c:1266:24: warning: variable 'request_ret' may be uninitialized when used here [-Wconditional-uninitialized] ../block/nbd.c:1424:20: warning: variable 'request_ret' may be uninitialized when used here [-Wconditional-uninitialized] ../block/qcow2-snapshot.c:423:51: warning: variable 'snapshots_size' may be uninitialized when used here [-Wconditional-uninitialized] ../block/qcow2.c:3236:23: warning: variable 'cur_bytes' may be uninitialized when used here [-Wconditional-uninitialized] ../block/ssh.c:306:52: warning: variable 'server_hash_len' may be uninitialized when used here [-Wconditional-uninitialized] ../block/ssh.c:313:45: warning: variable 'pubkey_type' may be uninitialized when used here [-Wconditional-uninitialized] ../contrib/elf2dmp/main.c:138:17: warning: variable 'kwn' may be uninitialized when used here [-Wconditional-uninitialized] ../contrib/elf2dmp/main.c:138:22: warning: variable 'kwa' may be uninitialized when used here [-Wconditional-uninitialized] ../contrib/elf2dmp/main.c:138:27: warning: variable 'KdpDataBlockEncoded' may be uninitialized when used here [-Wconditional-uninitialized] ../crypto/block-luks.c:844:29: warning: variable 'splitkeylen' may be uninitialized when used here [-Wconditional-uninitialized] ../disas/m68k.c:1513:47: warning: variable 'flval' may be uninitialized when used here [-Wconditional-uninitialized] ../dump/win_dump.c:105:18: warning: variable 'ptr64' may be uninitialized when used here [-Wconditional-uninitialized] ../dump/win_dump.c:105:26: warning: variable 'ptr32' may be uninitialized when used here [-Wconditional-uninitialized] ../gdbstub/gdbstub.c:1191:39: warning: variable 'pid' may be uninitialized when used here [-Wconditional-uninitialized] ../gdbstub/gdbstub.c:1209:36: warning: variable 'tid' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/9pfs/9p.c:1911:13: warning: variable 'fidst' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/block/block.c:110:33: warning: variable 'bs' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/core/generic-loader.c:160:23: warning: variable 'entry' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/i386/intel_iommu.c:323:12: warning: variable 'entry' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/ide/ahci.c:968:60: warning: variable 'tbl_entry_size' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/microblaze/boot.c:107:42: warning: variable 'fdt_size' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/net/rtl8139.c:1801:20: warning: variable 'buf2' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/nios2/boot.c:118:44: warning: variable 'fdt_size' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/nvram/fw_cfg.c:1254:40: warning: variable 'data' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/ppc/mac_oldworld.c:148:26: warning: variable 'bios_addr' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/ppc/spapr.c:274:55: warning: variable 'pa_size' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/riscv/microchip_pfsoc.c:609:54: warning: variable 'firmware_load_addr' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/s390x/css.c:553:9: warning: variable 'ret' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/s390x/ipl.c:410:17: warning: variable 'devtype' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/s390x/s390-pci-inst.c:156:39: warning: variable 'res_code' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/sd/sdhci.c:844:17: warning: variable 'res' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/sparc64/sun4u_iommu.c:159:66: warning: variable 'offset' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/xtensa/mx_pic.c:260:27: warning: variable 'oldv' may be uninitialized when used here [-Wconditional-uninitialized] ../hw/xtensa/mx_pic.c:260:33: warning: variable 'newv' may be uninitialized when used here [-Wconditional-uninitialized] ../migration/block.c:989:17: warning: variable 'ret' may be uninitialized when used here [-Wconditional-uninitialized] ../migration/migration.c:2847:17: warning: variable 'file' may be uninitialized when used here [-Wconditional-uninitialized] ../migration/ram.c:2088:24: warning: variable 'dirty' may be uninitialized when used here [-Wconditional-uninitialized] ../migration/savevm.c:721:30: warning: variable 'se' may be uninitialized when used here [-Wconditional-uninitialized] ../monitor/misc.c:1908:20: warning: variable 'snapshots' may be uninitialized when used here [-Wconditional-uninitialized] ../nbd/client-connection.c:419:9: warning: variable 'wait_co' may be uninitialized when used here [-Wconditional-uninitialized] ../net/socket.c:389:24: warning: variable 'saddr' may be uninitialized when used here [-Wconditional-uninitialized] ../net/tap-bsd.c:70:9: warning: variable 'fd' may be uninitialized when used here [-Wconditional-uninitialized] ../plugins/loader.c:406:17: warning: variable 'ctx' may be uninitialized when used here [-Wconditional-uninitialized] ../qemu-nbd.c:1175:22: warning: variable 'client_thread' may be uninitialized when used here [-Wconditional-uninitialized] ../softmmu/vl.c:1006:13: warning: variable 'opts' may be uninitialized when used here [-Wconditional-uninitialized] ../target/arm/helper.c:3299:17: warning: variable 'target_el' may be uninitialized when used here [-Wconditional-uninitialized] ../target/arm/m_helper.c:1727:37: warning: variable 'xpsr' may be uninitialized when used here [-Wconditional-uninitialized] ../target/arm/m_helper.c:1814:36: warning: variable 'shi' may be uninitialized when used here [-Wconditional-uninitialized] ../target/arm/m_helper.c:1814:48: warning: variable 'slo' may be uninitialized when used here [-Wconditional-uninitialized] ../target/arm/m_helper.c:1820:40: warning: variable 'fpscr' may be uninitialized when used here [-Wconditional-uninitialized] ../target/arm/translate-a64.c:10572:51: warning: variable 'rmode' may be uninitialized when used here [-Wconditional-uninitialized] ../target/arm/translate-a64.c:13225:51: warning: variable 'rmode' may be uninitialized when used here [-Wconditional-uninitialized] ../target/arm/translate-a64.c:8519:34: warning: variable 'tcg_src_hi' may be uninitialized when used here [-Wconditional-uninitialized] ../target/arm/translate.c:1590:50: warning: variable 'tmp' may be uninitialized when used here [-Wconditional-uninitialized] ../target/cris/mmu.c:201:33: warning: variable 'lo' may be uninitialized when used here [-Wconditional-uninitialized] ../target/i386/ops_sse.h:2492:15: warning: variable 'r0' may be uninitialized when used here [-Wconditional-uninitialized] ../target/i386/ops_sse.h:2493:15: warning: variable 'r1' may be uninitialized when used here [-Wconditional-uninitialized] ../target/i386/ops_sse.h:2494:15: warning: variable 'r2' may be uninitialized when used here [-Wconditional-uninitialized] ../target/i386/ops_sse.h:2495:15: warning: variable 'r3' may be uninitialized when used here [-Wconditional-uninitialized] ../target/m68k/softfloat.c:825:44: warning: variable 'm1' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1251:10: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1269:10: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1493:10: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1516:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1517:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1518:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1519:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1520:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1521:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1522:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1523:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1524:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1525:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1526:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1527:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1680:10: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:1954:10: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:2039:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:2040:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:2061:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:2062:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:2063:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:2064:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:2065:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:2066:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:2945:10: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:2956:10: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:2987:10: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:3063:10: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:967:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:968:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/int_helper.c:969:1: warning: variable 'result' may be uninitialized when used here [-Wconditional-uninitialized] ../target/ppc/mmu-radix64.c:548:20: warning: variable 'pte' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/ioinst.c:364:52: warning: variable 'irb_len' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/mem_helper.c:2978:12: warning: variable 'cc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:1023:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:132:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:156:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:278:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:301:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:439:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:471:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:551:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:592:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:635:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:659:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_fpu_helper.c:961:26: warning: variable 'vxc' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_helper.c:189:25: warning: variable 'tmp' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_helper.c:89:1: warning: variable 'tmp' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_helper.c:90:1: warning: variable 'tmp' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_helper.c:91:1: warning: variable 'tmp' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_int_helper.c:556:25: warning: variable 'tmp' may be uninitialized when used here [-Wconditional-uninitialized] ../target/s390x/tcg/vec_int_helper.c:606:25: warning: variable 'tmp' may be uninitialized when used here [-Wconditional-uninitialized] ../target/xtensa/translate.c:1074:51: warning: variable 'resource' may be uninitialized when used here [-Wconditional-uninitialized] ../target/xtensa/translate.c:1092:35: warning: variable 'temp' may be uninitialized when used here [-Wconditional-uninitialized] ../target/xtensa/translate.c:936:72: warning: variable 'rf' may be uninitialized when used here [-Wconditional-uninitialized] ../target/xtensa/xtensa-semi.c:297:17: warning: variable 'rc' may be uninitialized when used here [-Wconditional-uninitialized] ../tests/fp/berkeley-softfloat-3/source/s_shiftRightJam256M.c:117:10: warning: variable 'ptr' may be uninitialized when used here [-Wconditional-uninitialized] ../tests/fp/berkeley-testfloat-3/source/slowfloat.c:1015:13: warning: variable 'uiZ' may be uninitialized when used here [-Wconditional-uninitialized] ../tests/fp/berkeley-testfloat-3/source/slowfloat.c:742:13: warning: variable 'uiZ' may be uninitialized when used here [-Wconditional-uninitialized] ../tests/fp/berkeley-testfloat-3/source/slowfloat.c:878:13: warning: variable 'uiZ' may be uninitialized when used here [-Wconditional-uninitialized] ../tests/qtest/boot-sector.c:169:21: warning: variable 'signature' may be uninitialized when used here [-Wconditional-uninitialized] ../tests/qtest/prom-env-test.c:43:21: warning: variable 'signature' may be uninitialized when used here [-Wconditional-uninitialized] ../tests/unit/test-bdrv-drain.c:1022:21: warning: variable 'ret' may be uninitialized when used here [-Wconditional-uninitialized] ../tests/unit/test-block-iothread.c:772:14: warning: variable 'job' may be uninitialized when used here [-Wconditional-uninitialized] ../ui/vnc-enc-tight.c:416:1: warning: variable 'ci' may be uninitialized when used here [-Wconditional-uninitialized] ../ui/vnc-enc-tight.c:417:1: warning: variable 'ci' may be uninitialized when used here [-Wconditional-uninitialized] ../ui/vnc-enc-tight.c:418:1: warning: variable 'ci' may be uninitialized when used here [-Wconditional-uninitialized] ../util/iov.c:469:52: warning: variable 'mid_head' may be uninitialized when used here [-Wconditional-uninitialized] ../util/iov.c:471:36: warning: variable 'mid_tail' may be uninitialized when used here [-Wconditional-uninitialized] ../util/qemu-timer.c:198:12: warning: variable 'expire_time' may be uninitialized when used here [-Wconditional-uninitialized] ../util/qemu-timer.c:236:13: warning: variable 'expire_time' may be uninitialized when used here [-Wconditional-uninitialized] ../util/qemu-timer.c:476:9: warning: variable 'rearm' may be uninitialized when used here [-Wconditional-uninitialized]
| [Prev in Thread] | Current Thread | [Next in Thread] |