Re: [PATCH] target/i386/hax: Add XCR0 support

[Thomas Huth]

On 14/12/2022 10.15, Wang, Wenchao wrote:
> Hi, Thomas,
>
> As HAXM v7.8.0 is released and it added XCR0 support, it needs this patch to 
> add corresponding support into HAX user space of QEMU. I have pushed this 
> merge request before and Philippe has reviewed it and he thought the change 
> is correct. If no one else raises any other opinion, could you help to merge 
> this patch for HAX? 

 Hi,

sorry, I don't have a stake in the target/i386 code ... but you're listed as 
maintainer for the hax/ folder, so if no other x86 maintainer picks this up, 
I think you could send a pull request for this patch on your own. See:

 https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html

 HTH,
  Thomas


> ---------------------------------
>
>  From b1789f2523d06798b8883664bfa9a9df797bfccf Mon Sep 17 00:00:00 2001
>
> From: Wenchao Wang <wenchao.wang@intel.com <mailto:wenchao.wang@intel.com>>
>
> Date: Fri, 25 Nov 2022 18:37:34 +0800
>
> Subject: [PATCH] target/i386/hax: Add XCR0 support
>
> Introduce extended control register XCR0 to support XSAVE feature set.
>
> Note: This change requires at least HAXM v7.8.0 to support.
>
> Reviewed-by: Hang Yuan <hang.yuan@intel.com <mailto:hang.yuan@intel.com>>
>
> Signed-off-by: Wenchao Wang <wenchao.wang@intel.com 
> <mailto:wenchao.wang@intel.com>>
>
> ---
>
> target/i386/hax/hax-interface.h | 2 ++
>
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/i386/hax/hax-interface.h 
> b/target/i386/hax/hax-interface.h index 537ae084e9..1d13bb2380 100644
>
> --- a/target/i386/hax/hax-interface.h
>
> +++ b/target/i386/hax/hax-interface.h
>
> @@ -201,6 +201,8 @@ struct vcpu_state_t {
>
>       uint64_t _cr3;
>
>       uint64_t _cr4;
>
> +    uint64_t _xcr0;
>
> +
>
>       uint64_t _dr0;
>
>       uint64_t _dr1;
>
>       uint64_t _dr2;
>
> --
>
> 2.17.1