Re: [PATCH v2 0/2] qga: improve "syslog" domain logging

[Konstantin Kostiuk]

Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>

Tested-by: Konstantin Kostiuk <kkostiuk@redhat.com>

Hi Andrey,

Do you expect Event Viewer to be empty by default in the current implementation?

Currently, all logs that we write in the guest agent do not have "syslog" domain

so we will have logs only in file.

On Mon, Dec 12, 2022 at 2:29 PM Konstantin Kostiuk <kkostiuk@redhat.com> wrote:

Currently, there is a code freeze in QEMU for release 7.2.

I will merge this after it https://wiki.qemu.org/Planning/7.2

Best Regards,

Konstantin Kostiuk.

On Mon, Dec 12, 2022 at 2:17 PM Andrey Drobyshev <andrey.drobyshev@virtuozzo.com> wrote:

On 11/29/22 19:38, Andrey Drobyshev wrote:
> These patches extend QGA logging interface, primarily under Windows
> guests.  They enable QGA to write to Windows event log, much like
> syslog() on *nix.  In addition we get rid of hardcoded log level used by
> ga_log().
>
> v2:
> * Close event_log handle when doing cleanup_agent()
> * Fix switch cases indentation as reported by scripts/checkpatch.pl
>
> Andrey Drobyshev (2):
>   qga-win: add logging to Windows event log
>   qga: map GLib log levels to system levels
>
>  configure                 |  3 +++
>  qga/installer/qemu-ga.wxs |  5 ++++
>  qga/main.c                | 50 +++++++++++++++++++++++++++++++++++----
>  qga/meson.build           | 19 ++++++++++++++-
>  qga/messages-win32.mc     |  9 +++++++
>  5 files changed, 81 insertions(+), 5 deletions(-)
>  create mode 100644 qga/messages-win32.mc
>

Could you please clarify the status of these patches?