[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/2] qga: improve "syslog" domain logging
From: |
Andrey Drobyshev |
Subject: |
Re: [PATCH v2 0/2] qga: improve "syslog" domain logging |
Date: |
Fri, 16 Dec 2022 17:28:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 |
On 12/16/22 12:01, Konstantin Kostiuk wrote:
> Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com
> <mailto:kkostiuk@redhat.com>>
> Tested-by: Konstantin Kostiuk <kkostiuk@redhat.com
> <mailto:kkostiuk@redhat.com>>
>
>
> Hi Andrey,
> Do you expect Event Viewer to be empty by default in the current
> implementation?
> Currently, all logs that we write in the guest agent do not have
> "syslog" domain
> so we will have logs only in file.
>
> [...]
Do they not really? For instance, I see quite a few such calls in the
implementation of guest commands:
# grep 'slog(' qga/commands-win32.c | wc -l
21
They just need to be triggered. For instance, if I build QGA with these
patches applied, run it in a VM make a fsfreeze call:
# virsh domfsfreeze win2k16-qga-win
Froze 2 filesystem(s)
then I see the message "guest-fsfreeze called" in the event log.