Re: [PATCH v1 08/10] gdbstub: move chunk of softmmu functionality to own file

[Richard Henderson]

On 12/16/22 03:22, Alex Bennée wrote:
> This is mostly code motion but a number of things needed to be done
> for this minimal patch set:
>
>    - move shared structures to internals.h
>    - convert some helpers to public gdb_ functions (via internals.h)
>    - splitting some functions into user and softmmu versions
>    - fixing a few casting issues to keep softmmu common
>
> More CONFIG_USER_ONLY stuff will be handled in a following patches.
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> ---
>   gdbstub/internals.h  |  60 +++++
>   gdbstub/gdbstub.c    | 618 ++++++++-----------------------------------
>   gdbstub/softmmu.c    | 420 +++++++++++++++++++++++++++++
>   gdbstub/trace-events |   4 +-
>   4 files changed, 595 insertions(+), 507 deletions(-)

I think the last 3 patches all try to do too much at once.
I think each of the bullet points above could be done separately.


r~