Re: [PATCH v1 04/10] gdbstub: split GDBConnection from main structure

[Alex Bennée]

Fabiano Rosas <farosas@suse.de> writes:

> Alex Bennée <alex.bennee@linaro.org> writes:
>
>> In preparation for moving user/softmmu specific bits from the main
>> gdbstub file we need to separate the connection details to what will
>> eventually become an anonymous pointer.
<snip>
>> +
>> +    /*
>> +     * The following is differs depending on USER/SOFTMMU, we just
>> +     * hid it in the typedef.
>> +     */
>> +    gdbserver_state.connection = g_new(GDBConnection, 1);
>
> Does it need freeing at reset_gdbserver_state()?

Following Richard's suggestion I'll move to having separate static
structures instead to sidestep that problem.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro