Re: [PATCH] linux-user: ppoll: eliminate large alloca

[Richard Henderson]

On 12/16/22 11:22, Michael Tokarev wrote:
> do_ppoll() in linux-user/syscall.c uses alloca() to
> allocate an array of struct pullfds on the stack.
> The only upper boundary for number of entries for this
> array is so that whole thing fits in INT_MAX. But this
> is definitely too much for a stack allocation.
>
> Use heap allocation when large number of entries
> is requested (currently 128, arbitrary), and continue
> to use alloca() for smaller allocations, to optimize
> small operations for small sizes.

I think it would be cleaner to always use heap allocation, and use g_autofree 
for the pointer.


r~