Re: [PATCH v1 07/10] includes: add new gdbstub include directory

[Richard Henderson]

On 12/16/22 03:22, Alex Bennée wrote:
> To avoid having a messy set of include files containing system and
> user APIs lets prepare for a cleaner layout.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   include/gdbstub/common.h | 14 ++++++++++++++
>   include/gdbstub/user.h   | 14 ++++++++++++++
>   MAINTAINERS              |  1 +
>   3 files changed, 29 insertions(+)
>   create mode 100644 include/gdbstub/common.h
>   create mode 100644 include/gdbstub/user.h
>
> diff --git a/include/gdbstub/common.h b/include/gdbstub/common.h
> new file mode 100644
> index 0000000000..f928dbc487
> --- /dev/null
> +++ b/include/gdbstub/common.h
> @@ -0,0 +1,14 @@
> +/*
> + * gdbstub common APIs
> + *
> + * Copyright (c) 2022 Linaro Ltd
> + *
> + * SPDX-License-Identifier: LGPL-2.0+
> + */
> +
> +#ifndef GDBSTUB_COMMON_H
> +#define GDBSTUB_COMMON_H
> +
> +
> +
> +#endif /* GDBSTUB_COMMON_H */

I don't see any point in creating these headers separately from the patch that 
populates them.

Not keen on the name "common".  From the later patch, I think it may be at least 3 
separate headers: gdb syscalls, start/stop, xml.


r~