|
From: | Alex Bennée |
Subject: | Re: [PATCH v4 01/27] tcg: Fix tcg_reg_alloc_dup* |
Date: | Mon, 19 Dec 2022 15:49:30 +0000 |
User-agent: | mu4e 1.9.7; emacs 29.0.60 |
Richard Henderson <richard.henderson@linaro.org> writes: > The assignment to mem_coherent should be done with any > modification, not simply with a newly allocated register. What exactly does mem_coherent mean in this case? Is it that our register store is potentially out of sync with live values in temp regs or that we have memory loads and stores in flight? I think it would be useful to add a doc patch for TCGTemp do specify what the various fields mean. It would certainly help reviewers that don't have it committed to memory ;-) -- Alex Bennée Virtualisation Tech Lead @ Linaro
[Prev in Thread] | Current Thread | [Next in Thread] |