qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 01/27] tcg: Fix tcg_reg_alloc_dup*


From: Richard Henderson
Subject: Re: [PATCH v4 01/27] tcg: Fix tcg_reg_alloc_dup*
Date: Mon, 19 Dec 2022 10:17:39 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 12/19/22 07:49, Alex Bennée wrote:

Richard Henderson <richard.henderson@linaro.org> writes:

The assignment to mem_coherent should be done with any
modification, not simply with a newly allocated register.

What exactly does mem_coherent mean in this case? Is it that our
register store is potentially out of sync with live values in temp regs
or that we have memory loads and stores in flight?

I think it would be useful to add a doc patch for TCGTemp do specify
what the various fields mean. It would certainly help reviewers that
don't have it committed to memory ;-)


mem_coherent means that the register value and the memory value are the same, so that if we must release the register we do not need to save the value back to memory.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]