qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-8.0 4/7] hw/mips/gt64xxx_pci: Add a 'cpu-little-endian' q


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-8.0 4/7] hw/mips/gt64xxx_pci: Add a 'cpu-little-endian' qdev property
Date: Tue, 20 Dec 2022 09:06:55 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1

On 20/12/22 01:52, Richard Henderson wrote:
On 12/9/22 07:15, Philippe Mathieu-Daudé wrote:
+static Property gt64120_properties[] = {
+    DEFINE_PROP_BIT("cpu-little-endian", GT64120State,
+                    features, FEAT_CPU_LE, !TARGET_BIG_ENDIAN),

Unless you're really planning on more feature bits, DEFINE_PROP_BOOL would be better.

I can easily convert to DEFINE_PROP_BIT() if I ever get there...



reply via email to

[Prev in Thread] Current Thread [Next in Thread]