[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 16/18] ui: Split hmp_mouse_set() and move the HMP part to
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v3 16/18] ui: Split hmp_mouse_set() and move the HMP part to ui/ |
|
Date: |
Tue, 20 Dec 2022 09:15:53 +0000 |
|
User-agent: |
Mutt/2.2.7 (2022-08-07) |
On Tue, Dec 20, 2022 at 10:06:43AM +0100, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/monitor/hmp.h | 1 +
> include/ui/console.h | 2 +-
> monitor/misc.c | 1 -
> ui/input.c | 5 +----
> ui/ui-hmp-cmds.c | 8 ++++++++
> 5 files changed, 11 insertions(+), 6 deletions(-)
>
> -void hmp_mouse_set(Monitor *mon, const QDict *qdict)
> +void qemu_mouse_set(int index, Error **err)
This is adding a Error parameter, nit s/err/errp/
> {
> QemuInputHandlerState *s;
> - int index = qdict_get_int(qdict, "index");
> int found = 0;
>
> QTAILQ_FOREACH(s, &handlers, node) {
But not changing either error_report() call to error_setg(),
so the errp is unused.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v3 12/18] ui: Move more HMP commands from monitor to ui/, (continued)
[PATCH v3 05/18] ui/spice: Require spice-server >= 0.14.0, Markus Armbruster, 2022/12/20
[PATCH v3 11/18] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c, Markus Armbruster, 2022/12/20
[PATCH v3 08/18] ui: Clean up a few things checkpatch.pl would flag later on, Markus Armbruster, 2022/12/20
[PATCH v3 17/18] ui: Don't check for mode change after mouse_set error, Markus Armbruster, 2022/12/20
[PATCH v3 16/18] ui: Split hmp_mouse_set() and move the HMP part to ui/, Markus Armbruster, 2022/12/20
Re: [PATCH v3 00/18] ui: Move and clean up monitor command code, Philippe Mathieu-Daudé, 2022/12/20