Re: [PATCH v3 12/18] ui: Move more HMP commands from monitor to ui/

[Philippe Mathieu-Daudé]

On 20/12/22 12:49, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> > On 20/12/22 10:06, Markus Armbruster wrote:
> > > This moves these commands from MAINTAINERS section "Human
> > > Monitor (HMP)" to "Graphics".
> > > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > > ---
> > >    include/monitor/hmp.h |  2 ++
> > >    monitor/misc.c        | 66 -------------------------------------------
> > >    ui/ui-hmp-cmds.c      | 66 +++++++++++++++++++++++++++++++++++++++++++
> > >    3 files changed, 68 insertions(+), 66 deletions(-)
> >
> > You forgot to move hmp_sendkey() along.
>
> Moved in the previous patch.

Oops :)

> If I get your R-by, I'll squash the two patches together.

Hmm not needed, the previous patch is already big enough.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks!