[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/18] ui: Move more HMP commands from monitor to ui/
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v3 12/18] ui: Move more HMP commands from monitor to ui/ |
|
Date: |
Tue, 20 Dec 2022 12:49:24 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 20/12/22 10:06, Markus Armbruster wrote:
>> This moves these commands from MAINTAINERS section "Human
>> Monitor (HMP)" to "Graphics".
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> include/monitor/hmp.h | 2 ++
>> monitor/misc.c | 66 -------------------------------------------
>> ui/ui-hmp-cmds.c | 66 +++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 68 insertions(+), 66 deletions(-)
>
> You forgot to move hmp_sendkey() along.
Moved in the previous patch.
If I get your R-by, I'll squash the two patches together.
- [PATCH v3 18/18] ui: Simplify control flow in qemu_mouse_set(), (continued)
- [PATCH v3 18/18] ui: Simplify control flow in qemu_mouse_set(), Markus Armbruster, 2022/12/20
- [PATCH v3 07/18] ui/spice: Give hmp_info_spice()'s channel_names[] static linkage, Markus Armbruster, 2022/12/20
- [PATCH v3 06/18] ui/spice: QXLInterface method set_mm_time() is now dead, drop, Markus Armbruster, 2022/12/20
- [PATCH v3 03/18] ui/spice: Require spice-protocol >= 0.14.0, Markus Armbruster, 2022/12/20
- [PATCH v3 14/18] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c, Markus Armbruster, 2022/12/20
- [PATCH v3 15/18] ui: Reduce nesting in hmp_change_vnc() slightly, Markus Armbruster, 2022/12/20
- [PATCH v3 12/18] ui: Move more HMP commands from monitor to ui/, Markus Armbruster, 2022/12/20
[PATCH v3 05/18] ui/spice: Require spice-server >= 0.14.0, Markus Armbruster, 2022/12/20
[PATCH v3 11/18] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c, Markus Armbruster, 2022/12/20
[PATCH v3 08/18] ui: Clean up a few things checkpatch.pl would flag later on, Markus Armbruster, 2022/12/20
[PATCH v3 17/18] ui: Don't check for mode change after mouse_set error, Markus Armbruster, 2022/12/20
[PATCH v3 16/18] ui: Split hmp_mouse_set() and move the HMP part to ui/, Markus Armbruster, 2022/12/20