[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] include/hw/pci include/hw/cxl: Clean up includes
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 0/5] include/hw/pci include/hw/cxl: Clean up includes |
|
Date: |
Thu, 22 Dec 2022 08:02:48 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Fri, Dec 09, 2022 at 02:47:57PM +0100, Markus Armbruster wrote:
>> Back in 2016, we discussed[1] rules for headers, and these were
>> generally liked:
>>
>> 1. Have a carefully curated header that's included everywhere first. We
>> got that already thanks to Peter: osdep.h.
>>
>> 2. Headers should normally include everything they need beyond osdep.h.
>> If exceptions are needed for some reason, they must be documented in
>> the header. If all that's needed from a header is typedefs, put
>> those into qemu/typedefs.h instead of including the header.
>>
>> 3. Cyclic inclusion is forbidden.
>
> Looks like this breaks fuzzer build:
>
> https://gitlab.com/mstredhat/qemu/-/jobs/3506121308
Will be fixed in v2, thanks!
- Re: [PATCH 1/5] include/hw/pci: Clean up superfluous inclusion of pci*/*.h cxl/*.h, (continued)
[PATCH 4/5] include/hw/pci: Split pci_device.h off pci.h, Markus Armbruster, 2022/12/09
[PATCH 6/5] include/hw/cxl: Break inclusion loop, Markus Armbruster, 2022/12/09
Re: [PATCH 0/5] include/hw/pci include/hw/cxl: Clean up includes, Michael S. Tsirkin, 2022/12/21
- Re: [PATCH 0/5] include/hw/pci include/hw/cxl: Clean up includes,
Markus Armbruster <=