[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] hw/char: riscv_htif: Drop {to, from}host_size in HTIFS
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH 02/12] hw/char: riscv_htif: Drop {to, from}host_size in HTIFState |
|
Date: |
Wed, 28 Dec 2022 13:32:23 +1000 |
On Tue, Dec 27, 2022 at 4:56 PM Bin Meng <bmeng@tinylab.org> wrote:
>
> These are not used anywhere. Drop them.
>
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> include/hw/char/riscv_htif.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/hw/char/riscv_htif.h b/include/hw/char/riscv_htif.h
> index f888ac1b30..3eccc1914f 100644
> --- a/include/hw/char/riscv_htif.h
> +++ b/include/hw/char/riscv_htif.h
> @@ -33,8 +33,6 @@ typedef struct HTIFState {
>
> hwaddr tohost_offset;
> hwaddr fromhost_offset;
> - uint64_t tohost_size;
> - uint64_t fromhost_size;
> MemoryRegion mmio;
> MemoryRegion *address_space;
> MemoryRegion *main_mem;
> --
> 2.34.1
>
>
- [PATCH 00/12] hw/riscv: Improve Spike HTIF emulation fidelity, Bin Meng, 2022/12/27
- [PATCH 02/12] hw/char: riscv_htif: Drop {to, from}host_size in HTIFState, Bin Meng, 2022/12/27
- [PATCH 01/12] hw/char: riscv_htif: Avoid using magic numbers, Bin Meng, 2022/12/27
- [PATCH 04/12] hw/char: riscv_htif: Use conventional 's' for HTIFState, Bin Meng, 2022/12/27
- [PATCH 06/12] hw/char: riscv_htif: Remove forward declarations for non-existent variables, Bin Meng, 2022/12/27
- [PATCH 03/12] hw/char: riscv_htif: Drop useless assignment of memory region, Bin Meng, 2022/12/27