[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/12] hw/char: riscv_htif: Remove forward declarations for n
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH 06/12] hw/char: riscv_htif: Remove forward declarations for non-existent variables |
|
Date: |
Wed, 28 Dec 2022 14:22:09 +1000 |
On Tue, Dec 27, 2022 at 4:56 PM Bin Meng <bmeng@tinylab.org> wrote:
>
> There are forward declarations for 'vmstate_htif' and 'htif_io_ops'
> in riscv_htif.h however there are no definitions in the C codes.
>
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> include/hw/char/riscv_htif.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/hw/char/riscv_htif.h b/include/hw/char/riscv_htif.h
> index 55cc352331..9e8ebbe017 100644
> --- a/include/hw/char/riscv_htif.h
> +++ b/include/hw/char/riscv_htif.h
> @@ -40,9 +40,6 @@ typedef struct HTIFState {
> uint64_t pending_read;
> } HTIFState;
>
> -extern const VMStateDescription vmstate_htif;
> -extern const MemoryRegionOps htif_io_ops;
> -
> /* HTIF symbol callback */
> void htif_symbol_callback(const char *st_name, int st_info, uint64_t
> st_value,
> uint64_t st_size);
> --
> 2.34.1
>
>
- Re: [PATCH 02/12] hw/char: riscv_htif: Drop {to,from}host_size in HTIFState, (continued)
- [PATCH 01/12] hw/char: riscv_htif: Avoid using magic numbers, Bin Meng, 2022/12/27
- [PATCH 04/12] hw/char: riscv_htif: Use conventional 's' for HTIFState, Bin Meng, 2022/12/27
- [PATCH 06/12] hw/char: riscv_htif: Remove forward declarations for non-existent variables, Bin Meng, 2022/12/27
- [PATCH 03/12] hw/char: riscv_htif: Drop useless assignment of memory region, Bin Meng, 2022/12/27
- [PATCH 07/12] hw/char: riscv_htif: Support console output via proxy syscall, Bin Meng, 2022/12/27
- [PATCH 08/12] hw/riscv: spike: Remove the out-of-date comments, Bin Meng, 2022/12/27
- [PATCH 05/12] hw/char: riscv_htif: Move registers from CPUArchState to HTIFState, Bin Meng, 2022/12/27