Re: [PATCH v4 3/3] hw/intc/loongarch_pch: Change default irq number of pch irq controller

[Philippe Mathieu-Daudé]

On 30/12/22 10:59, Tianrui Zhao wrote:
> Change the default irq number of pch pic to 32, so that the irq
> number of pch msi is 224(256 - 32), and move the 'PCH_PIC_IRQ_NUM'
> macro to pci-host/ls7a.h and add prefix 'VIRT' on it to keep standard
> format.
>
> Signed-off-by: Tianrui Zhao <zhaotianrui@loongson.cn>
> ---
>   hw/intc/loongarch_pch_pic.c         | 3 ++-
>   hw/loongarch/virt.c                 | 2 +-
>   include/hw/intc/loongarch_pch_msi.h | 6 +++---
>   include/hw/intc/loongarch_pch_pic.h | 1 -
>   include/hw/pci-host/ls7a.h          | 1 +
>   5 files changed, 7 insertions(+), 6 deletions(-)


> diff --git a/include/hw/intc/loongarch_pch_msi.h 
> b/include/hw/intc/loongarch_pch_msi.h
> index c5a52bc327..a1172f56ff 100644
> --- a/include/hw/intc/loongarch_pch_msi.h
> +++ b/include/hw/intc/loongarch_pch_msi.h
> @@ -8,10 +8,10 @@
>   #define TYPE_LOONGARCH_PCH_MSI "loongarch_pch_msi"
>   OBJECT_DECLARE_SIMPLE_TYPE(LoongArchPCHMSI, LOONGARCH_PCH_MSI)
>   
> -/* Msi irq start start from 64 to 255 */
> -#define PCH_MSI_IRQ_START   64
> +/* Msi irq start start from 32 to 255 */

s/Msi/MSI/

Otherwise,

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>