[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/7] virtio-iommu: Fix error handling in virtio_iommu_set_host
From: |
Eric Auger |
Subject: |
[PATCH v2 1/7] virtio-iommu: Fix error handling in virtio_iommu_set_host_iova_ranges() |
Date: |
Mon, 1 Jul 2024 10:48:53 +0200 |
In case no IOMMUPciBus/IOMMUDevice are found we need to properly
set the error handle and return.
Fixes : Coverity CID 1549006
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Fixes: cf2647a76e ("virtio-iommu: Compute host reserved regions")
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
hw/virtio/virtio-iommu.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
index b9a7ddcd14..b708fb96fd 100644
--- a/hw/virtio/virtio-iommu.c
+++ b/hw/virtio/virtio-iommu.c
@@ -543,10 +543,15 @@ static int virtio_iommu_set_host_iova_ranges(VirtIOIOMMU
*s, PCIBus *bus,
int ret = -EINVAL;
if (!sbus) {
- error_report("%s no sbus", __func__);
+ error_setg(errp, "%s: no IOMMUPciBus found!", __func__);
+ return ret;
}
sdev = sbus->pbdev[devfn];
+ if (!sdev) {
+ error_setg(errp, "%s: no IOMMUDevice found!", __func__);
+ return ret;
+ }
current_ranges = sdev->host_resv_ranges;
--
2.41.0
- [PATCH v2 0/7] VIRTIO-IOMMU/HostIOMMUDevice: Fixes and page size mask rework, Eric Auger, 2024/07/01
- [PATCH v2 6/7] memory: remove IOMMU MR iommu_set_page_size_mask() callback, Eric Auger, 2024/07/01
- [PATCH v2 2/7] vfio-container-base: Introduce vfio_container_get_iova_ranges() helper, Eric Auger, 2024/07/01
- [PATCH v2 3/7] HostIOMMUDevice : remove Error handle from get_iova_ranges callback, Eric Auger, 2024/07/01
- [PATCH v2 1/7] virtio-iommu: Fix error handling in virtio_iommu_set_host_iova_ranges(),
Eric Auger <=
- [PATCH v2 4/7] HostIOMMUDevice: Introduce get_page_size_mask() callback, Eric Auger, 2024/07/01
- [PATCH v2 7/7] virtio-iommu: Revert transient enablement of IOMMU MR in bypass mode, Eric Auger, 2024/07/01
- [PATCH v2 5/7] virtio-iommu : Retrieve page size mask on virtio_iommu_set_iommu_device(), Eric Auger, 2024/07/01
- Re: [PATCH v2 0/7] VIRTIO-IOMMU/HostIOMMUDevice: Fixes and page size mask rework, Michael S. Tsirkin, 2024/07/01
- Re: [PATCH v2 0/7] VIRTIO-IOMMU/HostIOMMUDevice: Fixes and page size mask rework, Cédric Le Goater, 2024/07/01