[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 7/7] virtio-iommu: Revert transient enablement of IOMMU MR in
From: |
Eric Auger |
Subject: |
[PATCH v2 7/7] virtio-iommu: Revert transient enablement of IOMMU MR in bypass mode |
Date: |
Mon, 1 Jul 2024 10:48:59 +0200 |
In 94df5b2180d6 ("virtio-iommu: Fix 64kB host page size VFIO device
assignment"), in case of bypass mode, we transiently enabled the
IOMMU MR to allow the set_page_size_mask() to be called and pass
information about the page size mask constraint of cold plugged
VFIO devices. Now we do not use the IOMMU MR callback anymore, we
can just get rid of this hack.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
hw/virtio/virtio-iommu.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
index dc337a6805..72011d2d11 100644
--- a/hw/virtio/virtio-iommu.c
+++ b/hw/virtio/virtio-iommu.c
@@ -1387,18 +1387,6 @@ static void virtio_iommu_freeze_granule(Notifier
*notifier, void *data)
VirtIOIOMMU *s = container_of(notifier, VirtIOIOMMU, machine_done);
int granule;
- if (likely(s->config.bypass)) {
- /*
- * Transient IOMMU MR enable to collect page_size_mask requirements
- * through memory_region_iommu_set_page_size_mask() called by
- * VFIO region_add() callback
- */
- s->config.bypass = false;
- virtio_iommu_switch_address_space_all(s);
- /* restore default */
- s->config.bypass = true;
- virtio_iommu_switch_address_space_all(s);
- }
s->granule_frozen = true;
granule = ctz64(s->config.page_size_mask);
trace_virtio_iommu_freeze_granule(BIT_ULL(granule));
--
2.41.0
- [PATCH v2 0/7] VIRTIO-IOMMU/HostIOMMUDevice: Fixes and page size mask rework, Eric Auger, 2024/07/01
- [PATCH v2 6/7] memory: remove IOMMU MR iommu_set_page_size_mask() callback, Eric Auger, 2024/07/01
- [PATCH v2 2/7] vfio-container-base: Introduce vfio_container_get_iova_ranges() helper, Eric Auger, 2024/07/01
- [PATCH v2 3/7] HostIOMMUDevice : remove Error handle from get_iova_ranges callback, Eric Auger, 2024/07/01
- [PATCH v2 1/7] virtio-iommu: Fix error handling in virtio_iommu_set_host_iova_ranges(), Eric Auger, 2024/07/01
- [PATCH v2 4/7] HostIOMMUDevice: Introduce get_page_size_mask() callback, Eric Auger, 2024/07/01
- [PATCH v2 7/7] virtio-iommu: Revert transient enablement of IOMMU MR in bypass mode,
Eric Auger <=
- [PATCH v2 5/7] virtio-iommu : Retrieve page size mask on virtio_iommu_set_iommu_device(), Eric Auger, 2024/07/01
- Re: [PATCH v2 0/7] VIRTIO-IOMMU/HostIOMMUDevice: Fixes and page size mask rework, Michael S. Tsirkin, 2024/07/01
- Re: [PATCH v2 0/7] VIRTIO-IOMMU/HostIOMMUDevice: Fixes and page size mask rework, Cédric Le Goater, 2024/07/01