[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 38/40] gdbstub: Use true to set cmd_startswith
|
From: |
Manos Pitsidianakis |
|
Subject: |
Re: [PATCH v2 38/40] gdbstub: Use true to set cmd_startswith |
|
Date: |
Fri, 5 Jul 2024 13:03:08 +0300 |
On Fri, 5 Jul 2024 at 11:49, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> From: Gustavo Romero <gustavo.romero@linaro.org>
>
> cmd_startswith is a boolean so use 'true' to set it instead of 1.
>
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20240628050850.536447-10-gustavo.romero@linaro.org>
> ---
> gdbstub/gdbstub.c | 80 +++++++++++++++++++++++------------------------
> 1 file changed, 40 insertions(+), 40 deletions(-)
>
> diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
> index 5c1612ed2a..b9ad0a063e 100644
> --- a/gdbstub/gdbstub.c
> +++ b/gdbstub/gdbstub.c
> @@ -1433,26 +1433,26 @@ static const GdbCmdParseEntry gdb_v_commands_table[]
> = {
> {
> .handler = handle_v_cont_query,
> .cmd = "Cont?",
> - .cmd_startswith = 1
> + .cmd_startswith = true
> },
> {
> .handler = handle_v_cont,
> .cmd = "Cont",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .allow_stop_reply = true,
> .schema = "s0"
> },
> {
> .handler = handle_v_attach,
> .cmd = "Attach;",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .allow_stop_reply = true,
> .schema = "l0"
> },
> {
> .handler = handle_v_kill,
> .cmd = "Kill;",
> - .cmd_startswith = 1
> + .cmd_startswith = true
> },
> #ifdef CONFIG_USER_ONLY
> /*
> @@ -1462,25 +1462,25 @@ static const GdbCmdParseEntry gdb_v_commands_table[]
> = {
> {
> .handler = gdb_handle_v_file_open,
> .cmd = "File:open:",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "s,L,L0"
> },
> {
> .handler = gdb_handle_v_file_close,
> .cmd = "File:close:",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "l0"
> },
> {
> .handler = gdb_handle_v_file_pread,
> .cmd = "File:pread:",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "l,L,L0"
> },
> {
> .handler = gdb_handle_v_file_readlink,
> .cmd = "File:readlink:",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "s0"
> },
> #endif
> @@ -1748,7 +1748,7 @@ static const GdbCmdParseEntry
> gdb_gen_query_set_common_table[] = {
> {
> .handler = handle_set_qemu_sstep,
> .cmd = "qemu.sstep=",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "l0"
> },
> };
> @@ -1804,7 +1804,7 @@ static const GdbCmdParseEntry gdb_gen_query_table[] = {
> {
> .handler = handle_query_thread_extra,
> .cmd = "ThreadExtraInfo,",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "t0"
> },
> #ifdef CONFIG_USER_ONLY
> @@ -1816,14 +1816,14 @@ static const GdbCmdParseEntry gdb_gen_query_table[] =
> {
> {
> .handler = gdb_handle_query_rcmd,
> .cmd = "Rcmd,",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "s0"
> },
> #endif
> {
> .handler = handle_query_supported,
> .cmd = "Supported:",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "s0"
> },
> {
> @@ -1834,7 +1834,7 @@ static const GdbCmdParseEntry gdb_gen_query_table[] = {
> {
> .handler = handle_query_xfer_features,
> .cmd = "Xfer:features:read:",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "s:l,l0"
> },
> #if defined(CONFIG_USER_ONLY)
> @@ -1842,27 +1842,27 @@ static const GdbCmdParseEntry gdb_gen_query_table[] =
> {
> {
> .handler = gdb_handle_query_xfer_auxv,
> .cmd = "Xfer:auxv:read::",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "l,l0"
> },
> {
> .handler = gdb_handle_query_xfer_siginfo,
> .cmd = "Xfer:siginfo:read::",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "l,l0"
> },
> #endif
> {
> .handler = gdb_handle_query_xfer_exec_file,
> .cmd = "Xfer:exec-file:read:",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "l:l,l0"
> },
> #endif
> {
> .handler = gdb_handle_query_attached,
> .cmd = "Attached:",
> - .cmd_startswith = 1
> + .cmd_startswith = true
> },
> {
> .handler = gdb_handle_query_attached,
> @@ -1901,14 +1901,14 @@ static const GdbCmdParseEntry gdb_gen_set_table[] = {
> {
> .handler = handle_set_qemu_sstep,
> .cmd = "qemu.sstep:",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "l0"
> },
> #ifndef CONFIG_USER_ONLY
> {
> .handler = gdb_handle_set_qemu_phy_mem_mode,
> .cmd = "qemu.PhyMemMode:",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "l0"
> },
> #endif
> @@ -1916,7 +1916,7 @@ static const GdbCmdParseEntry gdb_gen_set_table[] = {
> {
> .handler = gdb_handle_set_catch_syscalls,
> .cmd = "CatchSyscalls:",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "s0",
> },
> #endif
> @@ -2012,7 +2012,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry target_halted_cmd_desc = {
> .handler = handle_target_halt,
> .cmd = "?",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .allow_stop_reply = true,
> };
> cmd_parser = &target_halted_cmd_desc;
> @@ -2023,7 +2023,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry continue_cmd_desc = {
> .handler = handle_continue,
> .cmd = "c",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .allow_stop_reply = true,
> .schema = "L0"
> };
> @@ -2035,7 +2035,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry cont_with_sig_cmd_desc = {
> .handler = handle_cont_with_sig,
> .cmd = "C",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .allow_stop_reply = true,
> .schema = "l0"
> };
> @@ -2047,7 +2047,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry v_cmd_desc = {
> .handler = handle_v_commands,
> .cmd = "v",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "s0"
> };
> cmd_parser = &v_cmd_desc;
> @@ -2064,7 +2064,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry detach_cmd_desc = {
> .handler = handle_detach,
> .cmd = "D",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "?.l0"
> };
> cmd_parser = &detach_cmd_desc;
> @@ -2075,7 +2075,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry step_cmd_desc = {
> .handler = handle_step,
> .cmd = "s",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .allow_stop_reply = true,
> .schema = "L0"
> };
> @@ -2087,7 +2087,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry backward_cmd_desc = {
> .handler = handle_backward,
> .cmd = "b",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .allow_stop_reply = true,
> .schema = "o0"
> };
> @@ -2099,7 +2099,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry file_io_cmd_desc = {
> .handler = gdb_handle_file_io,
> .cmd = "F",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "L,L,o0"
> };
> cmd_parser = &file_io_cmd_desc;
> @@ -2110,7 +2110,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry read_all_regs_cmd_desc = {
> .handler = handle_read_all_regs,
> .cmd = "g",
> - .cmd_startswith = 1
> + .cmd_startswith = true
> };
> cmd_parser = &read_all_regs_cmd_desc;
> }
> @@ -2120,7 +2120,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry write_all_regs_cmd_desc = {
> .handler = handle_write_all_regs,
> .cmd = "G",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "s0"
> };
> cmd_parser = &write_all_regs_cmd_desc;
> @@ -2131,7 +2131,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry read_mem_cmd_desc = {
> .handler = handle_read_mem,
> .cmd = "m",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "L,L0"
> };
> cmd_parser = &read_mem_cmd_desc;
> @@ -2142,7 +2142,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry write_mem_cmd_desc = {
> .handler = handle_write_mem,
> .cmd = "M",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "L,L:s0"
> };
> cmd_parser = &write_mem_cmd_desc;
> @@ -2153,7 +2153,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry get_reg_cmd_desc = {
> .handler = handle_get_reg,
> .cmd = "p",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "L0"
> };
> cmd_parser = &get_reg_cmd_desc;
> @@ -2164,7 +2164,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry set_reg_cmd_desc = {
> .handler = handle_set_reg,
> .cmd = "P",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "L?s0"
> };
> cmd_parser = &set_reg_cmd_desc;
> @@ -2175,7 +2175,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry insert_bp_cmd_desc = {
> .handler = handle_insert_bp,
> .cmd = "Z",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "l?L?L0"
> };
> cmd_parser = &insert_bp_cmd_desc;
> @@ -2186,7 +2186,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry remove_bp_cmd_desc = {
> .handler = handle_remove_bp,
> .cmd = "z",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "l?L?L0"
> };
> cmd_parser = &remove_bp_cmd_desc;
> @@ -2197,7 +2197,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry set_thread_cmd_desc = {
> .handler = handle_set_thread,
> .cmd = "H",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "o.t0"
> };
> cmd_parser = &set_thread_cmd_desc;
> @@ -2208,7 +2208,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry thread_alive_cmd_desc = {
> .handler = handle_thread_alive,
> .cmd = "T",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "t0"
> };
> cmd_parser = &thread_alive_cmd_desc;
> @@ -2219,7 +2219,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry gen_query_cmd_desc = {
> .handler = handle_gen_query,
> .cmd = "q",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "s0"
> };
> cmd_parser = &gen_query_cmd_desc;
> @@ -2230,7 +2230,7 @@ static int gdb_handle_packet(const char *line_buf)
> static const GdbCmdParseEntry gen_set_cmd_desc = {
> .handler = handle_gen_set,
> .cmd = "Q",
> - .cmd_startswith = 1,
> + .cmd_startswith = true,
> .schema = "s0"
> };
> cmd_parser = &gen_set_cmd_desc;
> --
> 2.39.2
>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
- [PATCH v2 34/40] target/arm: Make some MTE helpers widely available, (continued)
- [PATCH v2 34/40] target/arm: Make some MTE helpers widely available, Alex Bennée, 2024/07/05
- [PATCH v2 32/40] gdbstub: Add support for target-specific stubs, Alex Bennée, 2024/07/05
- [PATCH v2 26/40] plugins/lockstep: clean-up output, Alex Bennée, 2024/07/05
- [PATCH v2 24/40] plugins/lockstep: make mixed-mode safe, Alex Bennée, 2024/07/05
- [PATCH v2 14/40] tests/tcg/arm: Drop -N from LDFLAGS, Alex Bennée, 2024/07/05
- [PATCH v2 36/40] gdbstub: Make hex conversion function non-internal, Alex Bennée, 2024/07/05
- [PATCH v2 21/40] test/plugin: make insn plugin less noisy by default, Alex Bennée, 2024/07/05
- [PATCH v2 13/40] tests/tcg/arm: Fix fcvt result messages, Alex Bennée, 2024/07/05
- [PATCH v2 38/40] gdbstub: Use true to set cmd_startswith, Alex Bennée, 2024/07/05
- Re: [PATCH v2 38/40] gdbstub: Use true to set cmd_startswith,
Manos Pitsidianakis <=
- [PATCH v2 23/40] plugins/lockstep: preserve sock_path, Alex Bennée, 2024/07/05
- [PATCH v2 33/40] target/arm: Fix exception case in allocation_tag_mem_probe, Alex Bennée, 2024/07/05
- [PATCH v2 40/40] tests/tcg/aarch64: Add MTE gdbstub tests, Alex Bennée, 2024/07/05