[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/16] hw/sd/sdcard: Remove noise from sd_acmd_name()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 10/16] hw/sd/sdcard: Remove noise from sd_acmd_name() |
Date: |
Sat, 6 Jul 2024 00:04:28 +0200 |
These ACMD names weren't really useful, "UNKNOWN_ACMD" is simpler.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Tested-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Tested-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-77-philmd@linaro.org>
---
hw/sd/sd.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 43f60cf089..274a917ba6 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -257,23 +257,13 @@ static const char *sd_cmd_name(SDState *sd, uint8_t cmd)
static const char *sd_acmd_name(SDState *sd, uint8_t cmd)
{
- static const char *acmd_abbrev[SDMMC_CMD_MAX] = {
- [14] = "DPS_spec", [15] = "DPS_spec",
- [16] = "DPS_spec",
- [18] = "SECU_spec",
- [52] = "SECU_spec", [53] = "SECU_spec",
- [54] = "SECU_spec",
- [56] = "SECU_spec", [57] = "SECU_spec",
- [58] = "SECU_spec", [59] = "SECU_spec",
- };
const SDProto *sdp = sd->proto;
if (sdp->acmd[cmd].handler) {
- assert(!acmd_abbrev[cmd]);
return sdp->acmd[cmd].name;
}
- return acmd_abbrev[cmd] ? acmd_abbrev[cmd] : "UNKNOWN_ACMD";
+ return "UNKNOWN_ACMD";
}
static uint8_t sd_get_dat_lines(SDState *sd)
--
2.41.0
- [PULL 01/16] hw/sd/sdhci: Log non-sequencial access as GUEST_ERROR, (continued)
- [PULL 01/16] hw/sd/sdhci: Log non-sequencial access as GUEST_ERROR, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 02/16] hw/sd/npcm7xx_sdhci: Use TYPE_SYSBUS_SDHCI definition, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 03/16] tests/qtest/npcm7xx_sdhci: Access the card using its published address, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 04/16] hw/sd/sdcard: Generate random RCA value, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 05/16] hw/sd/sdcard: Remove leftover comment about removed 'spi' Property, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 06/16] hw/sd/sdcard: Use spec v3.01 by default, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 07/16] hw/sd/sdcard: Rename sd_cmd_SEND_OP_COND handler, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 08/16] hw/sd/sdcard: Add sd_cmd_GEN_CMD handler (CMD56), Philippe Mathieu-Daudé, 2024/07/05
- [PULL 09/16] hw/sd/sdcard: Remove sd_none enum from sd_cmd_type_t, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 10/16] hw/sd/sdcard: Remove noise from sd_acmd_name(),
Philippe Mathieu-Daudé <=
- [PULL 11/16] hw/sd/sdcard: Remove noise from sd_cmd_name(), Philippe Mathieu-Daudé, 2024/07/05
- [PULL 12/16] hw/sd/sdcard: Remove default case in read/write on DAT lines, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 14/16] hw/sd/sdcard: Cover more SDCardStates, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 13/16] hw/sd/sdcard: Trace length of data read on DAT lines, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 15/16] hw/sd/sdcard: Introduce set_csd/set_cid handlers, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 16/16] hw/sd/sdcard: Extract TYPE_SDMMC_COMMON from TYPE_SD_CARD, Philippe Mathieu-Daudé, 2024/07/05
- Re: [PULL 00/16] SD/MMC patches for 2024-07-06, Richard Henderson, 2024/07/07