[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/16] hw/sd/sdcard: Trace length of data read on DAT lines
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 13/16] hw/sd/sdcard: Trace length of data read on DAT lines |
Date: |
Sat, 6 Jul 2024 00:04:31 +0200 |
Some commands expect less than BLOCK_LENGTH.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Tested-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Tested-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240628070216.92609-80-philmd@linaro.org>
---
hw/sd/sd.c | 4 ++--
hw/sd/trace-events | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 3f495f91fe..9e6b9c9c63 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -2193,8 +2193,8 @@ uint8_t sd_read_byte(SDState *sd)
io_len = sd_blk_len(sd);
trace_sdcard_read_data(sd->proto->name,
- sd->last_cmd_name,
- sd->current_cmd, sd->data_offset, io_len);
+ sd->last_cmd_name, sd->current_cmd,
+ sd->data_offset, sd->data_size, io_len);
switch (sd->current_cmd) {
case 6: /* CMD6: SWITCH_FUNCTION */
case 9: /* CMD9: SEND_CSD */
diff --git a/hw/sd/trace-events b/hw/sd/trace-events
index 6a51b0e906..5dfe6be7b7 100644
--- a/hw/sd/trace-events
+++ b/hw/sd/trace-events
@@ -55,7 +55,7 @@ sdcard_req_addr(uint32_t req_arg, uint64_t addr) "req 0x%"
PRIx32 " addr 0x%" PR
sdcard_read_block(uint64_t addr, uint32_t len) "addr 0x%" PRIx64 " size 0x%x"
sdcard_write_block(uint64_t addr, uint32_t len) "addr 0x%" PRIx64 " size 0x%x"
sdcard_write_data(const char *proto, const char *cmd_desc, uint8_t cmd,
uint32_t offset, uint8_t value) "%s %20s/ CMD%02d ofs %"PRIu32" value 0x%02x"
-sdcard_read_data(const char *proto, const char *cmd_desc, uint8_t cmd,
uint32_t offset, uint32_t length) "%s %20s/ CMD%02d ofs %"PRIu32" len %" PRIu32
+sdcard_read_data(const char *proto, const char *cmd_desc, uint8_t cmd,
uint32_t offset, uint64_t size, uint32_t blklen) "%s %20s/ CMD%02d ofs
%"PRIu32" size %"PRIu64" blklen %" PRIu32
sdcard_set_voltage(uint16_t millivolts) "%u mV"
# pxa2xx_mmci.c
--
2.41.0
- [PULL 05/16] hw/sd/sdcard: Remove leftover comment about removed 'spi' Property, (continued)
- [PULL 05/16] hw/sd/sdcard: Remove leftover comment about removed 'spi' Property, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 06/16] hw/sd/sdcard: Use spec v3.01 by default, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 07/16] hw/sd/sdcard: Rename sd_cmd_SEND_OP_COND handler, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 08/16] hw/sd/sdcard: Add sd_cmd_GEN_CMD handler (CMD56), Philippe Mathieu-Daudé, 2024/07/05
- [PULL 09/16] hw/sd/sdcard: Remove sd_none enum from sd_cmd_type_t, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 10/16] hw/sd/sdcard: Remove noise from sd_acmd_name(), Philippe Mathieu-Daudé, 2024/07/05
- [PULL 11/16] hw/sd/sdcard: Remove noise from sd_cmd_name(), Philippe Mathieu-Daudé, 2024/07/05
- [PULL 12/16] hw/sd/sdcard: Remove default case in read/write on DAT lines, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 14/16] hw/sd/sdcard: Cover more SDCardStates, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 13/16] hw/sd/sdcard: Trace length of data read on DAT lines,
Philippe Mathieu-Daudé <=
- [PULL 15/16] hw/sd/sdcard: Introduce set_csd/set_cid handlers, Philippe Mathieu-Daudé, 2024/07/05
- [PULL 16/16] hw/sd/sdcard: Extract TYPE_SDMMC_COMMON from TYPE_SD_CARD, Philippe Mathieu-Daudé, 2024/07/05
- Re: [PULL 00/16] SD/MMC patches for 2024-07-06, Richard Henderson, 2024/07/07