[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 1/8] hw/loongarch/boot.c: fix out-of-bound reading
From: |
Song Gao |
Subject: |
[PULL v2 1/8] hw/loongarch/boot.c: fix out-of-bound reading |
Date: |
Fri, 12 Jul 2024 09:36:25 +0800 |
From: Dmitry Frolov <frolov@swemel.ru>
memcpy() is trying to READ 512 bytes from memory,
pointed by info->kernel_cmdline,
which was (presumable) allocated by g_strdup("");
Found with ASAN, making check with enabled sanitizers.
Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
Reviewed-by: Song Gao <gaosong@loongson.cn>
Message-Id: <20240628123910.577740-1-frolov@swemel.ru>
Signed-off-by: Song Gao <gaosong@loongson.cn>
---
hw/loongarch/boot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c
index b8e1aa18d5..cb668703bd 100644
--- a/hw/loongarch/boot.c
+++ b/hw/loongarch/boot.c
@@ -163,7 +163,7 @@ static void init_cmdline(struct loongarch_boot_info *info,
void *p, void *start)
info->a0 = 1;
info->a1 = cmdline_addr;
- memcpy(p, info->kernel_cmdline, COMMAND_LINE_SIZE);
+ g_strlcpy(p, info->kernel_cmdline, COMMAND_LINE_SIZE);
}
static uint64_t cpu_loongarch_virt_to_phys(void *opaque, uint64_t addr)
--
2.34.1
- [PULL v2 0/8] loongarch-to-apply queue, Song Gao, 2024/07/11
- [PULL v2 4/8] MAINTAINERS: Add myself as a reviewer of LoongArch virt machine, Song Gao, 2024/07/11
- [PULL v2 5/8] target/loongarch/kvm: Add software breakpoint support, Song Gao, 2024/07/11
- [PULL v2 1/8] hw/loongarch/boot.c: fix out-of-bound reading,
Song Gao <=
- [PULL v2 2/8] hw/loongarch: Change the tpm support by default, Song Gao, 2024/07/11
- [PULL v2 7/8] target/loongarch: Set CSR_PRCFG1 and CSR_PRCFG2 values, Song Gao, 2024/07/11
- [PULL v2 8/8] target/loongarch: Fix cpu_reset set wrong CSR_CRMD, Song Gao, 2024/07/11
- [PULL v2 3/8] hw/loongarch/virt: Remove unused assignment, Song Gao, 2024/07/11
- [PULL v2 6/8] target/loongarch: Remove avail_64 in trans_srai_w() and simplify it, Song Gao, 2024/07/11
- Re: [PULL v2 0/8] loongarch-to-apply queue, Richard Henderson, 2024/07/12