Re: [RFC PATCH 5/8] tests_pytest: Implement fetch_asset() method for downloading assets

[Thomas Huth]

On 11/07/2024 18.45, Richard Henderson wrote:
> On 7/11/24 04:55, Thomas Huth wrote:
> > +    def fetch_asset(self, url, asset_hash):
> > +        cache_dir = os.path.expanduser("~/.cache/qemu/download")
> > +        if not os.path.exists(cache_dir):
> > +            os.makedirs(cache_dir)
> > +        fname = os.path.join(cache_dir,
> > +                             hashlib.sha1(url.encode("utf-8")).hexdigest())
> > +        if os.path.exists(fname) and self.check_hash(fname, asset_hash):
> > +            return fname
> > +        logging.debug("Downloading %s to %s...", url, fname)
> > +        subprocess.check_call(["wget", "-c", url, "-O", fname + 
> > ".download"])
> > +        os.rename(fname + ".download", fname)
> > +        return fname
>
> Download failure via exception?
> Check hash on downloaded asset?

Yes, you're right, I'll add that. But that means it's also missing from 
_download_with_cache in tests/vm/basevm.py so far...

 Thomas