[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 6/8] tests/pytest: Convert some tests that download files
From: |
Daniel P . Berrangé |
Subject: |
Re: [RFC PATCH 6/8] tests/pytest: Convert some tests that download files via fetch_asset() |
Date: |
Fri, 12 Jul 2024 10:11:45 +0100 |
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Thu, Jul 11, 2024 at 01:55:44PM +0200, Thomas Huth wrote:
> Now that we've got a working fetch_asset() function, we can convert
> some Avocado tests that use this function for downloading their
> required files.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/pytest/meson.build | 16 +++++++++++++++
> .../test_machine_arm_n8x0.py} | 20 +++++++------------
> .../test_machine_avr6.py} | 7 ++-----
> .../test_machine_loongarch.py} | 11 ++++------
> .../test_machine_mips_loongson3v.py} | 19 ++++++------------
> 5 files changed, 35 insertions(+), 38 deletions(-)
> rename tests/{avocado/machine_arm_n8x0.py =>
> pytest/test_machine_arm_n8x0.py} (71%)
> rename tests/{avocado/machine_avr6.py => pytest/test_machine_avr6.py} (91%)
> rename tests/{avocado/machine_loongarch.py =>
> pytest/test_machine_loongarch.py} (89%)
> rename tests/{avocado/machine_mips_loongson3v.py =>
> pytest/test_machine_mips_loongson3v.py} (59%)
If you take my suggestion in the previous patch, the sha1 hashes
would need updating to sha256 hashes here. Aside from that
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests, John Snow, 2024/07/16