Re: [PATCH v2 0/4] virtio-net: Convert feature properties to OnOffAuto

[Akihiko Odaki]

On 2024/07/09 11:52, Jason Wang wrote:
> On Mon, Jul 8, 2024 at 3:38 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
> > Based-on: <20240428-rss-v10-0-73cbaa91aeb6@daynix.com>
> > ("[PATCH v10 00/18] virtio-net RSS/hash report fixes and improvements")
> >
> > Some features are not always available, and virtio-net used to disable
> > them when not available even if the corresponding properties were
> > explicitly set to "on".
> >
> > Convert feature properties to OnOffAuto so that the user can explicitly
> > tell QEMU to automatically select the value by setting them "auto".
> > QEMU will give an error if they are set "on".
>
> Would this be consumed by a management layer like libvirt?

No, as far as I know. I couldn't find any code that consumes the feature 
values and the patched binary worked with rss="on".

Regards,
Akihiko Odaki